Skip to content
This repository has been archived by the owner on Sep 24, 2019. It is now read-only.

4.1.1 ID tests fail with "." in ID's #349

Open
AccessibilityNL opened this issue Jun 18, 2015 · 2 comments
Open

4.1.1 ID tests fail with "." in ID's #349

AccessibilityNL opened this issue Jun 18, 2015 · 2 comments

Comments

@AccessibilityNL
Copy link

Several tests will look for elements based on their ID, including:

  • documentIDsMustBeUnique
  • idRefHasCorrespondingId
  • idrefsHasCorrespondingId

I'm not sure if any others do. What happens here is that the ID gets passed into a selector: $('#' + id);
This can fail when ID's contain values meaningful to CSS such as a period (.), such as an ID like id_0.123 We should make sure strings that are put into a selector are escaped.

@WilcoFiers
Copy link
Member

Whoops, wrong account. This above was me :)

@jessebeach
Copy link
Member

arg, good point :/

grumble grumble HTML ID spec...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants