Codegen dep (#155)

* remove dependency of essential package from codegen package to avoid circular dependency.

* fix #152 Print error log if there's no `BehaviorNode` attribute on an `INodeData` structure.

Author: quabug

Packages/codegen/package.json

@@ -1,17 +1,14 @@
 {
   "name": "com.quabug.entities-bt.codegen",
   "description": "Behavior Tree for Unity Entities - ILCodeGen",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "unity": "2020.2",
   "displayName": "EntitiesBT - IL CodeGen",
-  "dependencies": {
-    "com.quabug.entities-bt.essential": "1.1.0"
-  },
   "samples": [
     {
       "displayName": "[Test] tests",
       "description": "test cases of il codegen",
       "path": "Test~"
     }
   ]
-}
+}

Packages/essential/Editor/BehaviorNodeValidator.cs

@@ -4,6 +4,7 @@
 using System.Reflection;
 using EntitiesBT.Core;
 using UnityEditor.Callbacks;
+using UnityEngine;
 using static EntitiesBT.Core.Utilities;
 
 namespace EntitiesBT.Editor
@@ -16,12 +17,25 @@ public static void OnReload()
             var dictionary = new Dictionary<int, (Type type, BehaviorNodeAttribute attribute)>(128);
             foreach (var type in BEHAVIOR_TREE_ASSEMBLY_TYPES.Value)
             {
+                if (type.IsInterface
+                    || type.IsAbstract
+                    || type.IsGenericType
+                    || !typeof(INodeData).IsAssignableFrom(type))
+                    continue;
+
                 var attributes = type.GetCustomAttributes(typeof(BehaviorNodeAttribute));
-                if (!attributes.Any()) continue;
-                
+                if (!attributes.Any())
+                {
+                    Debug.LogError($"{type.FullName} must have a BehaviorNodeAttribute");
+                    continue;
+                }
+
                 var behaviorNodeAttribute = attributes.First() as BehaviorNodeAttribute;
                 if (dictionary.TryGetValue(behaviorNodeAttribute.Id, out var other))
-                    throw new Exception($"{other.type.FullName} has same id {behaviorNodeAttribute.Id} with {type.FullName}");
+                {
+                    Debug.LogError($"{other.type.FullName} has same id {behaviorNodeAttribute.Id} with {type.FullName}");
+                    continue;
+                }
                 dictionary.Add(behaviorNodeAttribute.Id, (type, behaviorNodeAttribute));
             }
         }

Packages/essential/package.json

@@ -1,11 +1,11 @@
 {
   "name": "com.quabug.entities-bt.essential",
   "description": "Behavior Tree for Unity Entities - Essential",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "unity": "2020.2",
   "displayName": "EntitiesBT - Essential",
   "dependencies": {
     "com.unity.entities": "0.14.0-preview.19",
-    "com.quabug.entities-bt.codegen": "1.0.0"
+    "com.quabug.entities-bt.codegen": "1.0.1"
   }
-}
+}

ProjectSettings/ProjectVersion.txt

@@ -1,2 +1,2 @@
-m_EditorVersion: 2020.2.4f1
-m_EditorVersionWithRevision: 2020.2.4f1 (becced5a802b)
+m_EditorVersion: 2020.2.6f1
+m_EditorVersionWithRevision: 2020.2.6f1 (8a2143876886)