qmlformat: Fix property names with escape chars

Formatter was breaking the string literal property names if they
consisted some escape sequences. Remove the complicated logic for
rewriting, instead  use the same literal that was scanned and assigned
to propertyName.

Pick-to: 6.5
Fixes: QTBUG-113776
Change-Id: I87d8c31d4893001e784536302e33f1f517f21acd
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
(cherry picked from commit 4c059a1)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit cf99be5)

Author: seyainc

src/qmldom/qqmldomreformatter.cpp

@@ -309,23 +309,7 @@ class Rewriter : protected BaseVisitor
             PatternProperty *assignment = AST::cast<PatternProperty *>(it->property);
             if (assignment) {
                 preVisit(assignment);
-                const bool isStringLike = [this](const SourceLocation &loc) {
-                    const auto name = loc2Str(loc);
-                    if (name.first() == name.last()) {
-                        if (name.first() == QStringLiteral("\'")
-                            || name.first() == QStringLiteral("\""))
-                            return true;
-                    }
-                    return false;
-                }(assignment->name->propertyNameToken);
-
-                if (isStringLike)
-                    out("\"");
-
                 accept(assignment->name);
-                if (isStringLike)
-                    out("\"");
-
                 bool useInitializer = false;
                 const bool bindingIdentifierExist = !assignment->bindingIdentifier.isEmpty();
                 if (assignment->colonToken.length > 0) {
@@ -396,7 +380,7 @@ class Rewriter : protected BaseVisitor
     }
     bool visit(StringLiteralPropertyName *ast) override
     {
-        out(ast->id.toString());
+        out(ast->propertyNameToken);
         return true;
     }
     bool visit(NumericLiteralPropertyName *ast) override

tests/auto/qml/qmlformat/data/escapeChars.formatted.qml

@@ -0,0 +1,15 @@
+import QtQuick
+
+Item {
+    x: {
+        const s = "\"";
+        let a = {
+            "\"": "\\"
+        };
+        let patron = {
+            "\\\"\n\n": "\?\?\\\"",
+            "": "",
+            "\'\"\n": 1
+        };
+    }
+}

tests/auto/qml/qmlformat/data/escapeChars.qml

@@ -0,0 +1,16 @@
+import QtQuick
+
+Item {
+    x: {
+        const s = "\""
+        let a = {
+            "\"": "\\"
+        };
+
+        let patron = {
+            "\\\"\n\n" : "\?\?\\\"","": "", "\'\"\n":1
+        };
+
+
+    }
+}

tests/auto/qml/qmlformat/tst_qmlformat.cpp

@@ -343,6 +343,9 @@ void TestQmlformat::testFormat_data()
     QTest::newRow("ellipsisFunctionArgument")
             << "ellipsisFunctionArgument.qml"
             << "ellipsisFunctionArgument.formatted.qml" << QStringList{} << RunOption::OnCopy;
+    QTest::newRow("escapeChars")
+            << "escapeChars.qml"
+            << "escapeChars.formatted.qml" << QStringList{} << RunOption::OnCopy;
 }
 
 void TestQmlformat::testFormat()