Split run_solar_cell_model function

[dalonsoa]

Problem

The main link between solcore and sunglass is in the sunglass.run_calculation.run_solar_cell_model, which is an extremely long function that does too many things and is rather fragile. Luckily, it is not that difficult to break it into smaller chunks each doing only one thing, since it is very sequential.

Proposed solution

The current code starting here:

sunglass/sunglass/run_calculation.py

Line 21 in f51044b

def run_solar_cell_model(task, model):

and running until the end of the file should be separated into smaller functions. This umbrella issue will be dealt with combining all those smaller functions to reproduce the existing functionality, but first those functions need to be created. Suggested functions to split things into are:

• Validate options (L28-L61) #5
• Create materials (L79-L91) #6
• Create layers (L64-L95, includes creating a material) #7
• Create junctions (L98-L112) #8
• Create substrate (L150-L155) #9

Appropriate tests to check that those individual building blocks work should be added, too. Once the above are done, then the existing run_solar_cell_model code can be refactored to use them.