ollama-integration: rename to ai-local-backend-integration #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any OpenAI-compatible backend is supported, so it would be better to maintain them in a single script and have seperate scripts for the ones that aren't compatible. This would also be clearer for users which might wrongly assume that only one backend is supported. This change also automatically adds the OpenAI endpoint to the base URL because all compatible backends support it already. Therefore, users only need to provide the local address.
Member
|
The problem is that you can only have one script with the same id. Means, if you have multiple different local (or remote) backends, then you can only use one with this script. So if you want to make one script for all use cases, please create a new script that supports multiple backends and also give hints about the API end points of the different backends... I, for example, wasn't aware that the chat API of ollama was not the OpenAI compatible API! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any OpenAI-compatible backend is supported, so it would be better to maintain them in a single script and have seperate scripts for the ones that aren't compatible.
This would also be clearer for users which might wrongly assume that only one backend is supported.
This change also automatically adds the OpenAI endpoint to the base URL because all compatible backends support it already. Therefore, users only need to provide the local address.