minor refactoring for better readability

Signed-off-by: Ceki Gulcu <ceki@qos.ch>
qos-ch · Nov 6, 2023 · 7ae0a7b · 7ae0a7b
1 parent f25df08
commit 7ae0a7b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/logback-core/src/main/java/ch/qos/logback/core/rolling/SizeAndTimeBasedFNATP.java b/logback-core/src/main/java/ch/qos/logback/core/rolling/SizeAndTimeBasedFNATP.java
@@ -157,6 +157,10 @@ public boolean isTriggeringEvent(File activeFile, final E event) {
             return true;
         }
 
+        return checkSizeBasedTrigger(activeFile, currentTime);
+    }
+
+    private boolean checkSizeBasedTrigger(File activeFile, long currentTime) {
         // next check for roll-over based on size
         if (invocationGate.isTooSoon(currentTime)) {
             return false;

diff --git a/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java b/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java
@@ -227,6 +227,13 @@ public String getActiveFileName() {
         }
     }
 
+    /**
+     * Delegates to the underlying timeBasedFileNamingAndTriggeringPolicy.
+     *
+     * @param activeFile A reference to the currently active log file.
+     * @param event      A reference to the current event.
+     * @return
+     */
     public boolean isTriggeringEvent(File activeFile, final E event) {
         return timeBasedFileNamingAndTriggeringPolicy.isTriggeringEvent(activeFile, event);
     }