Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform test compiles during qmk doctor. #24282

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Perform test compiles during qmk doctor. #24282

merged 6 commits into from
Nov 14, 2024

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Aug 15, 2024

Description

As per title.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team August 15, 2024 13:16
@github-actions github-actions bot added python cli qmk cli command labels Aug 15, 2024
tzarc and others added 2 commits August 16, 2024 08:40
@tzarc @noroadsleft
Update lib/python/qmk/cli/doctor/check.py
c934d2b 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@tzarc
Explicitly include newlib.h, use some defines from it. Invoke some bi…
9c396f7 
…nutils to verify that's working too.
@tzarc tzarc added the no-ci Signals to the CI runners not to build. label Aug 15, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Sep 30, 2024
@drashna drashna added the on hold label Oct 2, 2024
@drashna drashna removed the on hold label Nov 8, 2024
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Nov 11, 2024
@tzarc tzarc merged commit a8a47c4 into master Nov 14, 2024
5 checks passed
@tzarc tzarc deleted the doctor-check-compiles branch November 14, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft left review comments

@daskygit daskygit daskygit approved these changes

Assignees
No one assigned
Labels
cli qmk cli command no-ci Signals to the CI runners not to build. python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tzarc @noroadsleft @daskygit @drashna