Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Keyboard: HexBoard #22493

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

earboxer
Copy link
Contributor

@earboxer earboxer commented Nov 18, 2023

Added a new keyboard (with two revisions and two keymaps)

Description

The HexBoard is a MIDI Controller, but it also doubles as a 120% keyboard. Its default firmware focuses on the experience for musicians, but by running QMK firmware, it can be customized for all kinds of experiences.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • [-] I have read the PR Checklist document and have made the appropriate changes.
    • "readme.md: flash command is present, and has :flash at end" This command didn't work for me. Can we use a :flash command for RP2040-based boards?
    • "removed MIDI_ENABLE, FAUXCLICKY_ENABLE and HD44780_ENABLE" (I'm using MIDI, don't I need this?)
    • no “keymap only” features enabled : ENCODER_MAP_ENABLE (where should I enable this feature?
    • (please someone help with these so I can understand them)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    • Please squash-merge this PR
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/hexboard/config.h Outdated Show resolved Hide resolved
Copy link
Member

@waffle87 waffle87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code should not be duplicated where possible. eg.

hexboard
├── 1_1	# configuration that only applies to 1_1 hardware
│   ├── info.json
│   └── rules.mk
├── dev	# configuration that only applies to dev hardware
│   ├── info.json
│   └── rules.mk
├── hexboard.c	# code that applies to both revisions (eg. oled)
├── info.json	# configuration that applies to both models
└── keymaps
    └── default

Also, since OLEDs are enabled at the keyboard level, there needs to exist some keyboard level code to display something on them.

keyboards/hexboard/1_1/1_1.c Outdated Show resolved Hide resolved
keyboards/hexboard/1_1/1_1.c Outdated Show resolved Hide resolved
keyboards/hexboard/1_1/1_1.c Outdated Show resolved Hide resolved
keyboards/hexboard/1_1/rules.mk Outdated Show resolved Hide resolved
keyboards/hexboard/config.h Outdated Show resolved Hide resolved
keyboards/hexboard/info.json Outdated Show resolved Hide resolved
keyboards/hexboard/info.json Outdated Show resolved Hide resolved
keyboards/hexboard/readme.md Outdated Show resolved Hide resolved
keyboards/hexboard/rgb_matrix_kb.inc Outdated Show resolved Hide resolved
keyboards/hexboard/readme.md Outdated Show resolved Hide resolved
@waffle87
Copy link
Member

There are also compilation issues with the dev firmware. They can be viewed in the "QMK CI Build" link below.

@earboxer earboxer marked this pull request as draft November 26, 2023 02:04
@earboxer earboxer marked this pull request as ready for review December 2, 2023 21:09
keyboards/hexboard/1_1/config.h Show resolved Hide resolved
keyboards/hexboard/1_1/info.json Outdated Show resolved Hide resolved
keyboards/hexboard/1_1/rules.mk Outdated Show resolved Hide resolved
keyboards/hexboard/dev/config.h Show resolved Hide resolved
keyboards/hexboard/config.h Show resolved Hide resolved
keyboards/hexboard/keymaps/midi/config.h Show resolved Hide resolved
keyboards/hexboard/keymaps/keyboard/config.h Show resolved Hide resolved
keyboards/hexboard/matrix.c Outdated Show resolved Hide resolved
keyboards/hexboard/matrix.c Outdated Show resolved Hide resolved
keyboards/hexboard/rgb_matrix_kb.inc Outdated Show resolved Hide resolved
keyboards/hexboard/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hexboard/readme.md Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team January 13, 2024 07:01
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added stale Issues or pull requests that have become inactive without resolution. and removed stale Issues or pull requests that have become inactive without resolution. labels Feb 28, 2024
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Apr 15, 2024
@earboxer
Copy link
Contributor Author

earboxer commented Apr 15, 2024 via email

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Apr 16, 2024
@drashna
Copy link
Member

drashna commented May 2, 2024

Mostly, it's waiting on a second review, and I've flagged it as awaiting review to help with that.

keyboards/hexboard/matrix.c Outdated Show resolved Hide resolved
keyboards/hexboard/matrix.c Outdated Show resolved Hide resolved
keyboards/hexboard/matrix.c Outdated Show resolved Hide resolved
keyboards/hexboard/matrix.c Outdated Show resolved Hide resolved
keyboards/hexboard/matrix.c Outdated Show resolved Hide resolved
keyboards/hexboard/matrix.c Outdated Show resolved Hide resolved
keyboards/hexboard/1_1/info.json Outdated Show resolved Hide resolved
keyboards/hexboard/dev/info.json Outdated Show resolved Hide resolved
keyboards/hexboard/info.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants