Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forked let's split and did quite a bit of customization #22355

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

geoffreyborggaard
Copy link

@geoffreyborggaard geoffreyborggaard commented Oct 29, 2023

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@geoffreyborggaard geoffreyborggaard marked this pull request as draft October 29, 2023 00:51
@zvecr zvecr added the pr_checklist_pending Needs changes as per the PR checklist label Oct 29, 2023
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many of the settings can be migrated over by running qmk migrate or viewed with qmk info -kb split_ergo -f json

keyboards/split_ergo/info.json Show resolved Hide resolved
keyboards/split_ergo/keymaps/default/config.h Show resolved Hide resolved
keyboards/split_ergo/keymaps/default/config.h Show resolved Hide resolved
keyboards/split_ergo/keymaps/default/config.h Show resolved Hide resolved
Comment on lines +110 to +112
layer_state_t layer_state_set_user(layer_state_t state) {
return update_tri_layer_state(state, _LOWER, _RAISE, _ADJUST);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read that. I changed my raise and lower key codes to be the tri_layer ones. Not sure what else I need to do.

keyboards/split_ergo/rev2/rev2.h Show resolved Hide resolved
#endif

// Standard Keymap
#define LAYOUT( \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved to info.json.

Comment on lines 2 to 14
# change yes to no to disable
#
BOOTMAGIC_ENABLE = no # Enable Bootmagic Lite
MOUSEKEY_ENABLE = yes # Mouse keys
EXTRAKEY_ENABLE = yes # Audio control and System control
CONSOLE_ENABLE = no # Console for debug
COMMAND_ENABLE = yes # Commands for debug and configuration
NKRO_ENABLE = no # Enable N-Key Rollover
BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality
AUDIO_ENABLE = no # Audio output
RGBLIGHT_ENABLE = no # Enable WS2812 RGB underlight.

SPLIT_KEYBOARD = yes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be moved to info.json

keyboards/split_ergo/split_ergo.c Show resolved Hide resolved
keyboards/split_ergo/split_ergo.h Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run qmk format-json on this file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be removed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to follow the full template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap pr_checklist_pending Needs changes as per the PR checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants