Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] allow combos with dual function keys #8003

Closed
2 of 4 tasks
danielo515 opened this issue Jan 25, 2020 · 5 comments
Closed
2 of 4 tasks

[Feature Request] allow combos with dual function keys #8003

danielo515 opened this issue Jan 25, 2020 · 5 comments
Labels
enhancement help wanted stale Issues or pull requests that have become inactive without resolution.

Comments

@danielo515
Copy link
Contributor

Feature Request Type

  • Core functionality
  • Add-on hardware support (eg. audio, RGB, OLED screen, etc.)
  • Alteration (enhancement/optimization) of existing feature(s)
  • New behavior

Description

I just discovered combos and I'm amazed by the number of posibilities they brinng to my home row. However, most of my home row keys are dual function keys (h for meh, j for alt, k for control...) so I can't use them for combos. Is it possible to allow such kind of keys on combos? and if it not possible for now, will it be possible to implement?

@drashna
Copy link
Member

drashna commented Feb 8, 2020

I think you need to define COMBO_ALLOW_ACTION_KEYS, and then use the whole keycode.

@danielo515
Copy link
Contributor Author

Wow, didn't noticed that in the docs. Of course I suppose it is documented, but I didn't found it.
Thanks, I'll try it out for sure

@danielo515
Copy link
Contributor Author

Thanks for pointing it out @drashna . I looked for it on the docs and there is just one line that doesn't even make clear what it is that configuration for:

You may also be able to enable action keys by defining COMBO_ALLOW_ACTION_KEYS.

I tried it and, indeed it works, but it has severe drawbacks, which is that the keys you use for a combo no longer work for as dual function keys (in my case).

@stale
Copy link

stale bot commented May 16, 2020

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

@stale stale bot added the stale Issues or pull requests that have become inactive without resolution. label May 16, 2020
@stale
Copy link

stale bot commented Jun 15, 2020

This issue has been automatically closed because it has not had activity in the last 30 days. If this issue is still valid, re-open the issue and let us know.

@stale stale bot closed this as completed Jun 15, 2020
@Anton3 Anton3 mentioned this issue Nov 2, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Development

No branches or pull requests

2 participants