-
-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Massdrop requirements before next board gets merged #11119
Comments
Alternatively, feel free discuss with us the addition of RIOT-OS as a HAL instead of arm_atsam. Or anything else that has upstream support. |
Notably this replaces the custom debounce with the common debounce API which in turn resolves key double-pressing issues. The original debounce sets a timer when any key changes then stops all scanning until the timer expires. Since it is not scanning, the code cannot suppress long bounces or multiple keys bouncing at once. As a result, those events cause unwanted double presses. This fix could have patched the buggy debounce or integrated the debounce API, but converting to the lite API is simpler and reduces the amount of custom code to maintain. In theory this board doesn't strictly need any custom matrix code at all except that this platform lacks proper library support (see qmk#11119).
Did the merging of Massdrop/mdloader#62 suffice? |
No. That's only one of several part that are needed. the mdloader was more of a "bare minimum". |
This issue tracks the items required for QMK to merge any new Massdrop keyboards. The upstream protocol ("arm_atsam") is not in a state that the QMK collaborators are comfortable with, and as such have decided to decline future PRs targeting arm_atsam until the following cleanup occurs:
The i2c_master change will then enable the Massdrop boards to have the following transformations occur:
At this point we've raised qmk_firmware#10904 to warn users of Massdrop's lack of support -- if we gain some traction on the above issues this will no longer be necessary (or get reverted, if it subsequently merged).
Please try to minimise each change to a single subset of modifications -- historically Massdrop's PRs have included many unrelated changes and nobody decides to review. It'd be great if this could be avoided in future. It would also be preferable if there was an active contributor from Massdrop's side, as most of the PRs received seem to be abandonware once lodged -- any requested changes seem to be ignored.
The text was updated successfully, but these errors were encountered: