Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for NBA Teams info #7

Open
jeffmiller00 opened this issue Nov 11, 2019 · 2 comments
Open

Support for NBA Teams info #7

jeffmiller00 opened this issue Nov 11, 2019 · 2 comments

Comments

@jeffmiller00
Copy link

Hello - would you accept a PR to add functionality to fetch team information?

ex: http://data.nba.net/data/10s/prod/v1/current/standings_all_no_sort_keys.json

@qmateub
Copy link
Owner

qmateub commented Nov 11, 2019

Hey @jeffmiller00 !

First of all thanks for the suggestion and sure that you can open a PR for that 👍

I didn't have time to add the team information so thanks for that.

One question from my side:

Also would be cool if we can take care of team logos so it can be used later on with gatsby-image 😋

@jeffmiller00
Copy link
Author

We can add that one too, my use case requires the standings...so that's the one I threw in there first.

This will be my first React OSS PR, so I'll have someone take a look so that you're not dealing with 100% garbage. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants