Pin Qiskit to <2 in next release
#904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoaltamura
requested review from
woodsp-ibm,
adekusar-drl,
smens,
oscar-wallis,
OkuyanBoga and
Benjamin-Symons
as code owners
|
I am wondering - in the requirements.txt already exists a version limit for qiskit Would it be better to keep the version restrictions in one place especially since its a direct dependent i.e. |
Pull Request Test Coverage Report for Build 13954831611Details
💛 - Coveralls |
woodsp-ibm
approved these changes
Mar 20, 2025
There was a problem hiding this comment.
Just a comment to this:
The constraint can be removed when QML achieves full compatibility with Qiskit 2.
Before this it has a constraint >=1.0 so that rather than being removed (depending in what removed is exactly) the upper bound could be removed but that's likely then to become the lower bound i.e. >=2.0 I would think.
edoaltamura
added
the
stable backport potential
mergify bot
pushed a commit
that referenced
this pull request
May 22, 2025
* Pin Qiskit to `<2` in next release * Update constraints.txt * Update requirements.txt (cherry picked from commit de2cf2c) # Conflicts: # requirements.txt
woodsp-ibm
pushed a commit
that referenced
this pull request
May 22, 2025
* Pin Qiskit to `<2` in next release (#904) * Pin Qiskit to `<2` in next release * Update constraints.txt * Update requirements.txt (cherry picked from commit de2cf2c) # Conflicts: # requirements.txt * Update requirements.txt --------- Co-authored-by: Edoardo Altamura <38359901+edoaltamura@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pinning Qiskit<2 will avoid breaking changes to affect current installations. This potential effect was raised in #897. The constraint can be removed when QML achieves full compatibility with Qiskit 2.