Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add separate QUEUED and RUNNING states to task status #46

Closed
JordanAWS opened this issue Jun 15, 2022 · 1 comment · Fixed by #110
Closed

Add separate QUEUED and RUNNING states to task status #46

JordanAWS opened this issue Jun 15, 2022 · 1 comment · Fixed by #110
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone
0.0.4

Comments

@JordanAWS
Copy link
Collaborator

qiskit-braket-provider/qiskit_braket_provider/providers/braket_job.py

Line 132 in 1f64aae

status = JobStatus.RUNNING

Currently the provider assumes that tasks which have not thrown an error, been canceled, or finished are simply Running. This is not the case. We need a separate check to see if the status is QUEUED. Recommended change:

      if "FAILED" in braket_tasks_states:
          status = JobStatus.ERROR
      elif "CANCELLED" in braket_tasks_states:
          status = JobStatus.CANCELLED
      elif all(state == "COMPLETED" for state in braket_tasks_states):
          status = JobStatus.DONE
      elif all(state == "RUNNING" for state in braket_tasks_states):
          status = JobStatus.RUNNING
      else:
          status = JobStatus.QUEUED
@IceKhan13 IceKhan13 added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 15, 2022
@colegibbs colegibbs mentioned this issue Jun 16, 2022
Closed
@IceKhan13 IceKhan13 added this to the Release 0.0.3 milestone Jun 24, 2022
@IceKhan13 IceKhan13 modified the milestones: Release 0.0.3, 0.0.4 Dec 14, 2022
@robotAstray
Copy link
Contributor

robotAstray commented Jun 14, 2023 •
edited
Loading

do you still need help for this issue? @JordanAWS

@robotAstray robotAstray mentioned this issue Jun 14, 2023
Merged
robotAstray added a commit to robotAstray/qiskit-braket-provider that referenced this issue Jun 14, 2023
@robotAstray
add separate QUEUED and RUNNING states to task status (qiskit-communi…
355e7ae 
…ty#46)
robotAstray added a commit to robotAstray/qiskit-braket-provider that referenced this issue Jun 14, 2023
@robotAstray
add separate QUEUED and RUNNING states to task status (qiskit-communi…
23f4b05 
…ty#46)
robotAstray added a commit to robotAstray/qiskit-braket-provider that referenced this issue Jun 14, 2023
@robotAstray
add separate QUEUED and RUNNING states to task status (qiskit-communi…
8abed6c 
…ty#46)
robotAstray added a commit to robotAstray/qiskit-braket-provider that referenced this issue Jun 14, 2023
@robotAstray
add separate QUEUED and RUNNING states to task status (qiskit-communi…
674b5a6 
…ty#46)
robotAstray added a commit to robotAstray/qiskit-braket-provider that referenced this issue Jun 14, 2023
@robotAstray
add separate QUEUED and RUNNING states to task status (qiskit-communi…
9b2caa1 
…ty#46)
robotAstray added a commit to robotAstray/qiskit-braket-provider that referenced this issue Jun 14, 2023
@robotAstray
add separate QUEUED and RUNNING states to task status (qiskit-communi…
dd0d8e2 
…ty#46)
robotAstray added a commit to robotAstray/qiskit-braket-provider that referenced this issue Jun 14, 2023
@robotAstray
add separate QUEUED and RUNNING states to task status (qiskit-communi…
57f4743 
…ty#46)
christianbmadsen pushed a commit that referenced this issue Jun 19, 2023
@robotAstray @urihan
Adding separate QUEUED and RUNNING states to task status (#110)
a811b5e 
* fix: Updates for Qiskit to Braket circuit conversion (#97)

* Probability to Sample result type

* passes tox lint

* updates toxlint

* fixes observable z error but not passses elint

* unit test added

* final commit with tests

fix: Fallback to JAQCD for device properties (#104)

* fix: Fallback to JAQCD for device properties

* fix: reformat

replacing AWSBraketJob with AmazonBraketTask

run the notebooks containing AmazonBraketTask

deprecation warning added for AWSBraketJob class

formatting fixed

re-add <JOB_ARN>

fix breaking changes on /provider/__init__.py and __init__.py

rename job_id to task_id argument for AmazonBraketTask()

rename braket_jobs_states to braket_tasks_states

add task_id method to access the task_id similar to the one we have in the JobV1 class

adding tests for new class 'AmazonBraketTask' and old class 'AWSBraketJob'

formatting test_braket_job.py

correcting definition of AWSBraketJob

rewriting line 184 in braket_job.py

adding class docstring to AWSBraketJob

standard import 'from warnings import warn'  placed before 'from braket.aws import AwsQuantumTask' (wrong-import-order)

docstring fix in test_braket_job.py

assert the job id in test_AWS_job() function in test_braket_job.py

running how to notebook #0

running how to notebook #1

running how to notebook #2

running how to notebook #3

running how to notebook number 5

running tutorial  notebook number 3

tutorial number 0

* add separate QUEUED and RUNNING states to task status (#46)

---------

Co-authored-by: Yuri Han <45699207+urihan@users.noreply.github.com>
robotAstray added a commit to robotAstray/qiskit-braket-provider that referenced this issue Jun 19, 2023
@robotAstray @WingCode
@Gmontes01 @urihan
Update from qiskit-braket-provider main (#5)
02e7f89 
* [UnitaryHack] Enable qiskit transpilation discontinous qubit indices (qiskit-community#108)

* convert Rigetti Aspen qubit connectivity continous

* Add qiskit transpilation discountinous qubit indices

* Add more comments, cleanup

* Add more comments, cleanup

* Move in Rigetti branching since not require globally

* Fix lint

* Add better example

* Fix docstring

* Add mock for rigetti aspen m3

* Enable transpilation test

* Fix mypy

* [UnitaryHack] Gate Decomposition(qiskit-community#90) added and tested (qiskit-community#111)

* implement and test gate decomposition

* Implement and Test Gate Decomposition

* addressed comments in previous PR

* Adding separate QUEUED and RUNNING states to task status (qiskit-community#110)

* fix: Updates for Qiskit to Braket circuit conversion (qiskit-community#97)

* Probability to Sample result type

* passes tox lint

* updates toxlint

* fixes observable z error but not passses elint

* unit test added

* final commit with tests

fix: Fallback to JAQCD for device properties (qiskit-community#104)

* fix: Fallback to JAQCD for device properties

* fix: reformat

replacing AWSBraketJob with AmazonBraketTask

run the notebooks containing AmazonBraketTask

deprecation warning added for AWSBraketJob class

formatting fixed

re-add <JOB_ARN>

fix breaking changes on /provider/__init__.py and __init__.py

rename job_id to task_id argument for AmazonBraketTask()

rename braket_jobs_states to braket_tasks_states

add task_id method to access the task_id similar to the one we have in the JobV1 class

adding tests for new class 'AmazonBraketTask' and old class 'AWSBraketJob'

formatting test_braket_job.py

correcting definition of AWSBraketJob

rewriting line 184 in braket_job.py

adding class docstring to AWSBraketJob

standard import 'from warnings import warn'  placed before 'from braket.aws import AwsQuantumTask' (wrong-import-order)

docstring fix in test_braket_job.py

assert the job id in test_AWS_job() function in test_braket_job.py

running how to notebook #0

running how to notebook #1

running how to notebook #2

running how to notebook #3

running how to notebook number 5

running tutorial  notebook number 3

tutorial number 0

* add separate QUEUED and RUNNING states to task status (qiskit-community#46)

---------

Co-authored-by: Yuri Han <45699207+urihan@users.noreply.github.com>

---------

Co-authored-by: WingCode <smallstar1234@gmail.com>
Co-authored-by: Gmontes01 <118773601+Gmontes01@users.noreply.github.com>
Co-authored-by: Yuri Han <45699207+urihan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
0.0.4
Development

Successfully merging a pull request may close this issue.

Adding separate QUEUED and RUNNING states to task status robotAstray/qiskit-braket-provider
3 participants
@IceKhan13 @robotAstray @JordanAWS