Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkCrc 不能关闭 #364

Open
cpylua opened this issue Jul 17, 2020 · 2 comments · Fixed by #362
Open

checkCrc 不能关闭 #364

cpylua opened this issue Jul 17, 2020 · 2 comments · Fixed by #362
Labels
bug Something isn't working.

Comments

@cpylua
Copy link

cpylua commented Jul 17, 2020

nodejs-sdk/qiniu/storage/form.js

Line 29 in 4a41b36

this.checkCrc = checkCrc || true;

这里永远都是 true，关不掉。
@forrest-mao forrest-mao added the bug Something isn't working. label Jul 17, 2020
@forrest-mao
Copy link
Contributor

已知问题，在 7.3.2 版本中已经修复，https://github.com/qiniu/nodejs-sdk/releases/tag/v7.3.2 已经修复

@forrest-mao forrest-mao linked a pull request Jul 17, 2020 that will close this issue
v7.3.2 #363
Merged
@forrest-mao forrest-mao removed a link to a pull request Jul 17, 2020
v7.3.2 #363
Merged
@forrest-mao forrest-mao linked a pull request Jul 17, 2020 that will close this issue
Crc32 #362
Merged
@cpylua
Copy link
Author

cpylua commented Jul 17, 2020

你仔细看下master的代码，这个值永远不能设置成 false。

@forrest-mao forrest-mao reopened this Jul 24, 2020
@JemyCheung JemyCheung mentioned this issue Dec 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Crc32 JemyCheung/nodejs-sdk
2 participants
@cpylua @forrest-mao