-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix duplicate import of global var path in symlink file #351
Conversation
eg. main.go -> cmd/myproject/run.go When run `goc build .`, redeclared error will be reported. In main.go, the global var path is duplicated imported as follows: `package main; import . "myproject/src/gocbuild235e80d276dc"; import . "myproject/src/gocbuild234e80d276dc"`
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: IfanTsai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @CarlJi |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #351 +/- ##
==========================================
+ Coverage 70.61% 70.71% +0.09%
==========================================
Files 34 34
Lines 2042 2042
==========================================
+ Hits 1442 1444 +2
+ Misses 488 486 -2
Partials 112 112
Flags with carried forward coverage won't be shown. Click here to find out more. |
Hi @IfanTsai, I'm a bit confused about what you're referring to. Could you please provide a more complete example to clarify your request? |
Hi @CarlJi, here is our project structure demo:
This PR can ensure only once import, such as follows in
|
@IfanTsai Apologies for the delayed reply, the code LGTM, i will proceed with merging it |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CarlJi, IfanTsai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eg. main.go -> cmd/myproject/run.go
When run
goc build .
, redeclared error will be reported.In main.go, the global var path is duplicated imported as follows:
package main; import . "myproject/src/gocbuild235e80d276dc"; import . "myproject/src/gocbuild234e80d276dc"
These two files treaded as two unrelated files in result of
go list
command, so goc imports the global var package twice.