-
Notifications
You must be signed in to change notification settings - Fork 2
feat: standardize model label naming conventions #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Unified all model labels to use proper title case formatting - Updated the following model labels: * deepseek-v3 → DeepSeek V3 * deepseek-r1 → DeepSeek R1 * gpt-oss-120b → GPT-OSS 120B * gpt-oss-20b → GPT-OSS 20B * kimi-k2 → Kimi K2 * glm-4.5 → GLM-4.5 * glm-4.5-air → GLM-4.5 Air * qwen-turbo → Qwen Turbo * qwen3-32b → Qwen3 32B - Ensures consistency with existing models like Claude and Qwen3 Max Preview - Improves professional appearance and readability in user interface
- Added 'filename' field to matrix configuration for each build type
- Updated package naming to use filename instead of internal name
- This provides better control over release asset names:
* AI plugin: qiniu-ai-{version}.difypkg
* Storage plugin: qiniu-storage-{version}.difypkg
* Complete plugin: qiniu-cloud-{version}.difypkg
- Maintains backward compatibility while improving release asset naming clarity
🔍 PR Review Complete ✅I've thoroughly reviewed PR #15 - Model label standardization changes. 📋 Review Tasks
✅ Review SummaryThis PR successfully standardizes model labels across 9 YAML configuration files, transforming lowercase/kebab-case labels into proper title case formatting. The changes are well-executed and improve the professional appearance of the UI. 🎯 What This PR Does Well✅ Consistent Formatting
✅ Alignment with Existing Conventions
✅ Proper Brand Name Handling
🔍 Technical AnalysisFile Structure & Impact
Scope Coverage
📝 Minor SuggestionsDocumentation Sync
Future Considerations 💡
🏆 Verdict✅ APPROVED - This is a clean, well-executed standardization effort that:
The changes are ready to merge and will enhance the plugin's professional appearance in the Dify interface. 👉 Want me to re-run this review? Just type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @yinxulai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to improve the user interface's clarity and professionalism by standardizing the naming conventions for various large language model labels. By converting existing labels to a consistent title case format, the change enhances readability and maintains a unified appearance across the platform, aligning with the presentation of other established models.
Highlights
- Standardized Model Labels: All model labels have been unified to follow a consistent title case formatting, improving overall presentation and user experience.
- Specific Model Updates: Nine specific model labels, including DeepSeek V3, DeepSeek R1, GPT-OSS 120B, GPT-OSS 20B, Kimi K2, GLM-4.5, GLM-4.5 Air, Qwen Turbo, and Qwen3 32B, have been updated to reflect the new naming convention.
- Enhanced Readability and Consistency: This change ensures consistency with existing models like Claude and Qwen3 Max Preview, significantly enhancing the professional appearance and readability of model names within the user interface.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request standardizes the display labels for several language models, improving UI consistency and readability by using title case. The changes are well-executed across all affected model configuration files. I've pointed out a couple of opportunities to improve the Chinese (zh_Hans) labels for the Qwen models to use their native Chinese names, which would enhance the experience for Chinese-speaking users. Otherwise, the changes look good.
| label: | ||
| zh_Hans: qwen-turbo | ||
| en_US: qwen-turbo | ||
| zh_Hans: Qwen Turbo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| label: | ||
| zh_Hans: qwen3-32b | ||
| en_US: qwen3-32b | ||
| zh_Hans: Qwen3 32B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unified all model labels to use proper title case formatting
Updated the following model labels:
Ensures consistency with existing models like Claude and Qwen3 Max Preview
Improves professional appearance and readability in user interface