-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Add multi-package support and CI/CD workflows #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
yinxulai
commented
Sep 10, 2025
- Add GitHub Actions workflows for automated testing and release
- Implement matrix build strategy for three package types:
- qiniu-models: AI inference services only
- qiniu-tools: Cloud storage management tools only
- qiniu: Complete package with both AI and storage features
- Add separate AI model provider implementation (qiniu_ai.py)
- Update provider configurations for modular architecture
- Support automatic package generation and release asset upload
- Add GitHub Actions workflows for automated testing and release - Implement matrix build strategy for three package types: * qiniu-models: AI inference services only * qiniu-tools: Cloud storage management tools only * qiniu: Complete package with both AI and storage features - Add separate AI model provider implementation (qiniu_ai.py) - Update provider configurations for modular architecture - Support automatic package generation and release asset upload
🔍 PR Review: Multi-package Support and CI/CD WorkflowsOverviewThis PR introduces a sophisticated matrix build strategy to generate three distinct package variants from a single codebase. The implementation is well-architected and addresses a real need for modular distribution. ✅ Strengths1. Excellent Modular Architecture
2. Robust CI/CD Implementation
3. Good Security Practices
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @yinxulai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the project's architecture by introducing a multi-package structure and automating the build and release processes. The changes aim to provide more granular control over package distribution and streamline development workflows through robust CI/CD pipelines.
Highlights
- Multi-package Architecture: Introduces support for three distinct package types: qiniu-models (AI inference), qiniu-tools (cloud storage), and qiniu (complete package), enabling modular distribution.
- Automated CI/CD Workflows: Implements GitHub Actions for automated testing and release processes, including a matrix build strategy for the new package types and automatic package generation/release asset upload.
- AI Model Provider Refactoring: Separates the AI model provider implementation into a dedicated file (qiniu_ai.py) and updates related configurations for a more modular design.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces multi-package support for the Qiniu provider by splitting it into AI-only, tools-only, and a complete package, and adds CI/CD workflows. My review of the configuration changes found that while the labels for the new packages have been updated, the descriptions have not been fully aligned with the new package structure. I've left comments on these inconsistencies, as correcting them will improve clarity for users.
| label: | ||
| en_US: Qiniu Cloud | ||
| zh_Hans: 七牛云 | ||
| zh_Hans: 七牛云 AI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While changing the label to 七牛云 AI is correct for the AI-only package, the description on lines 6-7 is now inconsistent. It still mentions 'cloud storage management' and related features. To align with the multi-package structure, please update the description to only include AI inference services.
For example:
en_US: Official Qiniu Cloud Dify plugin providing comprehensive AI inference services. Supports multiple LLM models including GPT-OSS、deepseek、GLM、Kimi、Qwen series.zh_Hans: 七牛云官方 Dify 插件,提供全面的 AI 推理服务。支持 GPT-OSS、deepseek、GLM、Kimi、Qwen 系列等多种大语言模型。
| label: | ||
| en_US: Qiniu Cloud | ||
| zh_Hans: 七牛云 | ||
| zh_Hans: 七牛云存储 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new label 七牛云存储 is appropriate for the tools-only package. However, the description on lines 8-9 should be updated. It currently includes 'AI inference services', which is not part of this package. Please revise the description to focus solely on cloud storage management capabilities.
For example:
en_US: Official Qiniu Cloud Dify plugin providing cloud storage management. Offers complete file management capabilities such as file upload, bucket operations, and content retrieval.zh_Hans: 七牛云官方 Dify 插件,提供云存储管理功能。提供完整的文件管理能力,包括文件上传、存储空间操作和内容获取等功能。
- Remove description and description_zh fields from matrix configuration - Keep only package name dynamic replacement in manifest.yaml - Simplify workflow configuration by using original manifest descriptions - Maintain consistency between release.yml and runnable.yml workflows
- Update manifest.yaml to reference qiniu_ai.yaml instead of qiniu.yaml - Fix provider_source path in qiniu_ai.yaml to point to qiniu_ai.py - Ensure consistency between file naming and configuration references
- Add explicit plugins configuration based on package type - Prevent cross-package conflicts by ensuring manifest only references existing files - Add validation logic to configure plugins section for: * ai packages: only models configuration * kodo packages: only tools configuration * all packages: both models and tools configuration - Improve build reliability and package isolation
- Add label_en and label_zh fields to matrix configuration - Update manifest.yaml to set package-specific names and labels: * qiniu-models: 'Qiniu AI Models' / '七牛云 AI 模型' * qiniu-tools: 'Qiniu Storage Tools' / '七牛云存储工具' * qiniu: 'Qiniu Cloud' / '七牛云' - Ensure consistent branding across different package types - Apply changes to both release.yml and runnable.yml workflows
- Rename AI package from 'qiniu-models' to 'qiniu-ai' for better clarity - Simplify package labels for cleaner presentation: * Qiniu AI Models → Qiniu AI * Qiniu Storage Tools → Qiniu Storage - Update both release.yml and runnable.yml workflows consistently - Maintain clear distinction between package types while using concise naming