Skip to content

Commit ec6f9b5

Browse files
committed
self.ca_cert
1 parent 3cc5f66 commit ec6f9b5

File tree

4 files changed

+14
-15
lines changed

4 files changed

+14
-15
lines changed

qiita_client/qiita_client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@
3232
# responses from the server so let's make the retries values small
3333
if logger.level != logging.CRITICAL:
3434
MAX_RETRIES = 2
35-
MIN_TIME_SLEEP = 3
36-
MAX_TIME_SLEEP = 10
35+
MIN_TIME_SLEEP = 2
36+
MAX_TIME_SLEEP = 5
3737
else:
3838
MAX_RETRIES = 3
3939
MIN_TIME_SLEEP = 180

qiita_client/testing.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
import logging
1616

1717
logger = logging.getLogger(__name__)
18-
URL = "https://127.0.0.1:8383"
18+
URL = "https://localhost:8383"
1919

2020

2121
class PluginTestCase(TestCase):
@@ -25,12 +25,12 @@ def setUpClass(cls):
2525
cls.client_id = '19ndkO3oMKsoChjVVWluF7QkxHRfYhTKSFbAVt8IhK7gZgDaO4'
2626
cls.client_secret = ('J7FfQ7CQdOxuKhQAf1eoGgBAE81Ns8Gu3EKaWFm3IO2JKh'
2727
'AmmCWZuabe0O5Mp28s1')
28-
cls.rootca = environ.get('QIITA_ROOTCA_CERT')
28+
cls.ca_cert = environ.get('QIITA_ROOTCA_CERT')
2929

3030
# do not rely on defining ca_cert for these tests. Instead append
3131
# the appropriate CA cert to certifi's pem file.
3232
cls.qclient = QiitaClient(
33-
URL, cls.client_id, cls.client_secret, cls.rootca)
33+
URL, cls.client_id, cls.client_secret, cls.ca_cert)
3434

3535
logger.debug(
3636
'PluginTestCase.setUpClass() token %s' % cls.qclient._token)

qiita_client/tests/test_plugin.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
from qiita_client.testing import PluginTestCase
1717
from qiita_client import (QiitaPlugin, QiitaTypePlugin, QiitaCommand,
1818
QiitaArtifactType, ArtifactInfo)
19-
from .testing import URL
2019

20+
URL = 'https://localhost:21174'
2121

2222
class QiitaCommandTest(TestCase):
2323
def setUp(self):

qiita_client/tests/test_qiita_client.py

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
from qiita_client.qiita_client import (QiitaClient, _format_payload,
1717
ArtifactInfo)
18-
from qiita_client.testing import PluginTestCase
18+
from qiita_client.testing import PluginTestCase, URL
1919
from qiita_client.exceptions import BadRequestError
2020

2121
CLIENT_ID = '19ndkO3oMKsoChjVVWluF7QkxHRfYhTKSFbAVt8IhK7gZgDaO4'
@@ -97,11 +97,9 @@ def test_format_payload_error(self):
9797

9898
class QiitaClientTests(PluginTestCase):
9999
def setUp(self):
100-
self.ca_cert = environ.get('QIITA_ROOT_CA')
101-
self.tester = QiitaClient("https://localhost:8383",
100+
self.tester = QiitaClient(URL,
102101
CLIENT_ID,
103-
CLIENT_SECRET,
104-
self.ca_cert)
102+
CLIENT_SECRET, self.ca_cert)
105103
self.clean_up_files = []
106104

107105
# making assertRaisesRegex compatible with Python 2.7 and 3.9
@@ -114,11 +112,11 @@ def tearDown(self):
114112
remove(fp)
115113

116114
def test_init(self):
117-
obs = QiitaClient("https://localhost:8383",
115+
obs = QiitaClient(URL,
118116
CLIENT_ID,
119117
CLIENT_SECRET,
120118
ca_cert=self.ca_cert)
121-
self.assertEqual(obs._server_url, "https://localhost:8383")
119+
self.assertEqual(obs._server_url, URL)
122120
self.assertEqual(obs._client_id, CLIENT_ID)
123121
self.assertEqual(obs._client_secret, CLIENT_SECRET)
124122
self.assertEqual(obs._verify, self.ca_cert)
@@ -243,13 +241,14 @@ def test_update_job_step_ignore_failure(self):
243241

244242
# confirm that update_job_step behaves as before when ignore_error
245243
# parameter absent or set to False.
246-
self.bad_tester = QiitaClient("https://localhost:8383",
244+
self.bad_tester = QiitaClient(URL,
247245
BAD_CLIENT_ID,
248246
CLIENT_SECRET,
249247
self.ca_cert)
250248

251249
with self.assertRaises(BaseException):
252-
self.bad_tester.update_job_step(job_id, new_step)
250+
self.bad_tester.update_job_step(
251+
job_id, new_step, ignore_error=False)
253252

254253
with self.assertRaises(BaseException):
255254
self.bad_tester.update_job_step(job_id,

0 commit comments

Comments
 (0)