Skip to content

2023.10 #3321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2023
Merged

2023.10 #3321

merged 2 commits into from
Oct 13, 2023

Conversation

antgonza
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

coverage: 92.915% (-0.004%) from 92.919% when pulling 4fdee57 on antgonza:2023.10 into b733ad3 on qiita-spots:dev.

Copy link
Contributor

@charles-cowart charles-cowart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Everything looks good.

@charles-cowart
Copy link
Contributor

@antgonza Will confirm before merging.

Copy link
Contributor

@charles-cowart charles-cowart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The code changes appear good. It looks the meat of the solution for the outstanding issue is in the changes to the notebooks themselves. The notebooks are quite in-depth but it appears that they are in order.

@charles-cowart charles-cowart merged commit ac62aba into qiita-spots:dev Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants