Fix ILIKE parameters quoted params #2375
Conversation
Codecov Report
@@ Coverage Diff @@
## release-candidate #2375 +/- ##
=====================================================
+ Coverage 93.76% 93.77% +<.01%
=====================================================
Files 163 163
Lines 18647 18668 +21
=====================================================
+ Hits 17485 17505 +20
- Misses 1162 1163 +1
Continue to review full report at Codecov.
|
qiita_db/processing_job.py
Outdated
| params = [command.id] + params | ||
| TTRN.add(sql, params) | ||
| else: | ||
| TTRN.add(sql.format(""), [command.id]) |
There was a problem hiding this comment.
Do you mind adding a comment here on why there is a need for a call to format with an empty string? I had to read the 3 or 4 times until I realized why it was needed.
| @@ -948,5 +953,27 @@ def test_remove_error(self): | |||
| tester.remove(tester.graph.edges()[0][0]) | |||
|
|
|||
|
|
|||
| @qiita_test_checker() | |||
| class ProcessingJobDuplicated(TestCase): | |||
There was a problem hiding this comment.
Is there a specific reason why you've created a different class here? That triggers a new reset of the DB, it will be great if we can avoid a reset of DB unless strictly necessary.
There was a problem hiding this comment.
As we are setting all the jobs to error the other tests are failing. I think we have 2 options: A. reset back but it seemed ugly to me or B. have it as a different class so the reset happens, this seemed better to me
There was a problem hiding this comment.
Nah, it's okay - I just wanted to make sure that there was an actual reason to create the class.
No description provided.