-
Notifications
You must be signed in to change notification settings - Fork 80
adds EBI submission of shotgun samples #2303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds EBI submission of shotgun samples #2303
Conversation
Codecov Report
@@ Coverage Diff @@
## release-candidate #2303 +/- ##
=================================================
Coverage 93.8% 93.8%
=================================================
Files 163 163
Lines 18581 18581
=================================================
Hits 17430 17430
Misses 1151 1151
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given test pass
The submission is finally done and was successful. This is ready to go. Now, my guess is that this should be moved to the release-candidate branch, right? BTW the submission is still not in the main qiita, I'll start moving files now. Once the code and the files are in place I'll resubmit from the main qiita so we can have a full submission. |
Yes - can you do the PR against release-candidate? |
Is that good enough? |
I think so - can you pull from upstream/release-candidate and push just to make sure that everything is sync-ed? |
…into sg-to-EBI
Done. |
This is still being tested in our test environment but in theory these are all the required changes.
Now, I think this should go to the release candidate but for some reason, if I try to do the PR against that branch it raises a bunch of conflicts ... any ideas?