Skip to content

adds EBI submission of shotgun samples #2303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 26, 2017

Conversation

antgonza
Copy link
Member

This is still being tested in our test environment but in theory these are all the required changes.

Now, I think this should go to the release candidate but for some reason, if I try to do the PR against that branch it raises a bunch of conflicts ... any ideas?

@codecov-io
Copy link

codecov-io commented Sep 20, 2017

Codecov Report

Merging #2303 into release-candidate will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-candidate   #2303   +/-   ##
=================================================
  Coverage               93.8%   93.8%           
=================================================
  Files                    163     163           
  Lines                  18581   18581           
=================================================
  Hits                   17430   17430           
  Misses                  1151    1151
Impacted Files Coverage Δ
...pet/handlers/api_proxy/tests/test_prep_template.py 98.68% <ø> (ø) ⬆️
qiita_db/metadata_template/constants.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b14656...d01d1e4. Read the comment docs.

Copy link
Contributor

@josenavas josenavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given test pass

@antgonza
Copy link
Member Author

The submission is finally done and was successful. This is ready to go. Now, my guess is that this should be moved to the release-candidate branch, right?

BTW the submission is still not in the main qiita, I'll start moving files now. Once the code and the files are in place I'll resubmit from the main qiita so we can have a full submission.

@josenavas
Copy link
Contributor

Yes - can you do the PR against release-candidate?

@antgonza antgonza changed the base branch from dev to release-candidate September 26, 2017 15:00
@antgonza
Copy link
Member Author

Is that good enough?

@josenavas
Copy link
Contributor

I think so - can you pull from upstream/release-candidate and push just to make sure that everything is sync-ed?

@antgonza
Copy link
Member Author

Done.

@josenavas josenavas changed the title WIP: adds EBI submission of shotgun samples adds EBI submission of shotgun samples Sep 26, 2017
@ElDeveloper ElDeveloper merged commit a9155b5 into qiita-spots:release-candidate Sep 26, 2017
@antgonza antgonza deleted the sg-to-EBI branch February 17, 2018 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants