Skip to content

Fix 2212 #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 6, 2017
Merged

Fix 2212 #2257

merged 3 commits into from
Sep 6, 2017

Conversation

josenavas
Copy link
Contributor

Fixes #2212

The text input now gets focused when opening the modal:

focus

@codecov-io
Copy link

codecov-io commented Aug 29, 2017

Codecov Report

Merging #2257 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2257      +/-   ##
==========================================
+ Coverage   92.82%   92.82%   +<.01%     
==========================================
  Files         171      171              
  Lines       18930    18930              
==========================================
+ Hits        17571    17572       +1     
+ Misses       1359     1358       -1
Impacted Files Coverage Δ
qiita_db/test/test_analysis.py 98.01% <0%> (-0.34%) ⬇️
...t/handlers/api_proxy/tests/test_sample_template.py 98.66% <0%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef4f566...7d5da5c. Read the comment docs.

@ElDeveloper
Copy link
Contributor

Looks good! Although outside of the scope of this PR maybe also worth it to make enter submit the change?

@adswafford adswafford merged commit 9a8d271 into qiita-spots:dev Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants