Skip to content

Join using instead on db issues #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 29, 2015
Merged

Join using instead on db issues #1126

merged 13 commits into from
Apr 29, 2015

Conversation

josenavas
Copy link
Contributor

Fixes the errors seen by @antgonza

ElDeveloper and others added 7 commits April 27, 2015 16:18
@ElDeveloper
ENH: Meta Analysis -> Analysis
dbf7ad5 
Users have frequently pointed out that naming this tab as "Meta
Analysis" is misleading and that a better name would be simply Analysis.
@ElDeveloper
ENH: ✨ the magic of grep✨
af5423c
@josenavas
Merge pull request qiita-spots#1112 from ElDeveloper/minor-wording
33e5404 
ENH: Meta Analysis -> Analysis
@ElDeveloper
BUG: Fix bug in moi.init
13fa06e 
The position of the group_id argument was moved and the rest of the code
was not updated to reflect this. This change set moves group_id so it is
the first argument.
@ElDeveloper
BUG: Update code using moi.init
9cdc4c5 
Fix qiita-spots#1124
@josenavas
Reverting the comment from @squirrelo on search for JOIN...ON -> USIN…
a546233 
…G cause it currently breaks
@josenavas
Removing the ambiguity
402003a
@josenavas josenavas added this to the Alpha 0.1 milestone Apr 29, 2015
@antgonza
Copy link
Member

👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.24% when pulling f73887f on josenavas:join-using-instead-on-db-issues into 7390538 on biocore:relax-md-req.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.24% when pulling f73887f on josenavas:join-using-instead-on-db-issues into 7390538 on biocore:relax-md-req.

@squirrelo
Copy link
Contributor

👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.25% when pulling fa2392c on josenavas:join-using-instead-on-db-issues into 7390538 on biocore:relax-md-req.

antgonza added a commit that referenced this pull request Apr 29, 2015
@antgonza
Merge pull request #1126 from josenavas/join-using-instead-on-db-issues
1a163fb 
Join using instead on db issues
@antgonza antgonza merged commit 1a163fb into qiita-spots:relax-md-req Apr 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
priority: high
Projects
None yet
Milestone
Alpha 0.1
Development

Successfully merging this pull request may close these issues.
5 participants
@josenavas @antgonza @coveralls @squirrelo @ElDeveloper