Fix sample obj #1074
Merged
Fix sample obj #1074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
#1073 was just merged, can you pull upstream on this? |
…fix-sample-obj
|
@squirrelo Done! |
|
👍 |
|
Looks good. @squirrelo @josenavas is there a way to test this, or are we merging everything into the |
|
@adamrp all the functionality is not in place after a couple more PR. I think the best path is to review the code to see if there is anything horribly wrong, and then wait for the PR that everything is in place to make sure that everything is correct. Is really hard to test until everything is in place, but if the code looks good, I can fix the remaining issues later. Does everybody agrees with that? |
|
@josenavas, yes that's a good strategy moving forward. |
|
great! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is build on top of
#1072(merged) and #1073. At least #1072 should be merged in master before merging this one, so the commits from there (quite a few) disappear here.This PR fixes the BaseSample, Sample and PrepSample objects and their tests. The tests for these objects are expected to pass.