Delete preprocess data #1042
Delete preprocess data #1042
Conversation
| preprocessed data EBI and VAMPS submission is not in a valid state | ||
| ['not submitted', 'failed'] | ||
| QiitaDBError | ||
| If the preprocessed data has (meta)analyses |
There was a problem hiding this comment.
This is not accurate: If the preprocessed data has been processed
|
Just a documentation comment. Once it is fixed, 👍 |
|
I tried deleting a Preprocessed data object that had already generated a processed data object and I got the following error:
And I honestly don't understand what that means. |
| ppd = cls(ppd_id) | ||
| if ppd.status != 'sandbox': | ||
| raise QiitaDBStatusError( | ||
| "Illegal operation on non sandbox preprocessed data") |
There was a problem hiding this comment.
Since these messages (832 and 836) are likely to be seen by users on the GUI, do you think you could rephrase them?
There was a problem hiding this comment.
Thanks for the changes. I think it should be "sandboxed" not "sandbox".
|
Couple of comments. |
| with self.assertRaises(QiitaDBStatusError): | ||
| PreprocessedData.delete(1) | ||
|
|
||
| def test_delete_advance(self): |
|
Testing on my system. |
|
Looks good from my testing the only outstanding thing is that, it gave me the following message even though I never submitted to EBI:
I attach the whole screenshot, because it may be that the EBI status it has is messing with the check? Not sure why is this the case though. |
|
To the rest of the qiita devs, the reason why this is failing for some studies is because 'false' is not a valid status for the EBI submission. The |
No description provided.