Skip to content

Commit 7286364

Browse files
committed
Fixing indexing
1 parent ff4315e commit 7286364

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Since Qiita is a package that is continuously growing, we found ourselves in a p
2020
1. HTML files and DBS files (from DBSchema) do not count, but JavaScript does
2121
2. Test data do not count toward the line limit
2222
3. PR over this limit will only be allowed if it has been discussed with the developer team and it can potentially be done in a different branch.
23-
2. The code in the master branch should always be consistent. If your PR is leaving master in an inconsistent state, it's a red flag that more changes need to be done, and the code has to go to its own branch until all modifications get in (see 1.1). Ideally, these branches should exist for a short period of time (~24h) before getting merged into master again, in order to avoid merge conflicts. This means that both developers and reviewers agree on working/reviewing these issues fast.
23+
2. The code in the master branch should always be consistent. If your PR is leaving master in an inconsistent state, it's a red flag that more changes need to be done, and the code has to go to its own branch until all modifications get in (see 1. iii). Ideally, these branches should exist for a short period of time (~24h) before getting merged into master again, in order to avoid merge conflicts. This means that both developers and reviewers agree on working/reviewing these issues fast.
2424
3. If you are changing code and the reviewers provide suggestions on how to improve the code, make the change unless you can demonstrate that your current implementation is better than the suggestion. Suggested changes must also explain why they are better when given, and make a reasonable case for the change. Examples:
2525
* For performance improvements, the reviewer should provide code using IPython's `%timeit` magic (or similar).
2626
* Point to the [Contributing.md](https://github.com/biocore/qiita/blob/master/CONTRIBUTING.md) and/or the Code Guidelines (under construction).

0 commit comments

Comments
 (0)