Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not export namespace in header file #109

Merged
merged 2 commits into from
Jul 4, 2023
Merged

do not export namespace in header file #109

merged 2 commits into from
Jul 4, 2023

Conversation

muxiaozi
Copy link

@muxiaozi muxiaozi commented Jul 3, 2023

避免在头文件中导出命名空间

@qicosmos
Copy link
Owner

qicosmos commented Jul 3, 2023

谢谢你的pr。
处理一下代码格式，建议用 clang-format 13或14

@qicosmos qicosmos self-requested a review July 4, 2023 02:32
qicosmos
qicosmos approved these changes Jul 4, 2023
View reviewed changes
Copy link
Owner

@qicosmos qicosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qicosmos qicosmos merged commit 93088a7 into qicosmos:master Jul 4, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qicosmos qicosmos qicosmos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muxiaozi @qicosmos