Update install module & tests

Author: qgadrian

lib/mix/tasks/git_hooks/install.ex

@@ -135,8 +135,7 @@ defmodule Mix.Tasks.GitHooks.Install do
 
   @spec ensure_hooks_folder_exists() :: any
   defp ensure_hooks_folder_exists do
-    "/"
-    |> GitPath.git_hooks_path_for()
+    GitPath.resolve_git_hooks_path()
     |> File.mkdir_p()
   end
 

test/mix/tasks/git_hooks/install_test.exs

@@ -3,13 +3,14 @@ defmodule Mix.Tasks.InstallTest do
 
   use ExUnit.Case, async: false
   use GitHooks.TestSupport.ConfigCase
+  use GitHooks.TestSupport.GitProjectCase
 
   alias Mix.Tasks.GitHooks.Install
 
   @tag capture_log: true
 
   describe "run/1" do
-    test "replaces the hook template with config values" do
+    test "replaces the hook template with config values", %{tmp_dir: project_path} do
       put_git_hook_config(
         [:pre_commit, :pre_push],
         tasks: {:cmd, "check"}
@@ -18,24 +19,27 @@ defmodule Mix.Tasks.InstallTest do
       hooks_file = Install.run(["--dry-run", "--quiet"])
 
       assert hooks_file == [
-               pre_commit: expect_hook_template("pre_commit"),
-               pre_push: expect_hook_template("pre_push")
+               pre_commit: expect_hook_template("pre_commit", project_path),
+               pre_push: expect_hook_template("pre_push", project_path)
              ]
     end
 
-    test "allows setting a custom path to execute the hook" do
+    test "allows setting a custom path to execute the hook", %{tmp_dir: project_path} do
       put_git_hook_config(
         [:pre_commit, :pre_push],
         tasks: {:cmd, "check"}
       )
 
-      Application.put_env(:git_hooks, :project_path, "a_custom_path")
+      custom_path = Path.join(project_path, "a_custom_path")
+      File.mkdir_p!(custom_path)
+      System.cmd("git", ["init"], cd: custom_path)
+      Application.put_env(:git_hooks, :project_path, custom_path)
 
       hooks_file = Install.run(["--dry-run", "--quiet"])
 
       assert hooks_file == [
-               pre_commit: expect_hook_template("pre_commit", "a_custom_path"),
-               pre_push: expect_hook_template("pre_push", "a_custom_path")
+               pre_commit: expect_hook_template("pre_commit", custom_path),
+               pre_push: expect_hook_template("pre_push", custom_path)
              ]
 
       Application.delete_env(:git_hooks, :project_path)
@@ -46,7 +50,7 @@ defmodule Mix.Tasks.InstallTest do
   # Private functions
   #
 
-  defp expect_hook_template(git_hook, project_path \\ "") do
+  defp expect_hook_template(git_hook, project_path) do
     ~s(#!/bin/sh
 
 [ "#{project_path}" != "" ] && cd "#{project_path}"