Skip to content

Commit df6e103

Browse files
authored
Support boolean values for additionalProperties (OpenAPITools#266)
Fixes OpenAPITools#256
1 parent d1a92d1 commit df6e103

File tree

4 files changed

+2313
-2
lines changed

4 files changed

+2313
-2
lines changed

core/src/main/java/org/openapitools/openapidiff/core/compare/schemadiffresult/SchemaDiffResult.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,8 @@ private void compareAdditionalProperties(
146146
Object left = leftSchema.getAdditionalProperties();
147147
Object right = rightSchema.getAdditionalProperties();
148148
if (left instanceof Schema || right instanceof Schema) {
149-
Schema leftAdditionalSchema = (Schema) left;
150-
Schema rightAdditionalSchema = (Schema) right;
149+
Schema leftAdditionalSchema = left instanceof Schema ? (Schema) left : null;
150+
Schema rightAdditionalSchema = right instanceof Schema ? (Schema) right : null;
151151
ChangedSchema apChangedSchema =
152152
new ChangedSchema()
153153
.setContext(context)
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
package org.openapitools.openapidiff.core;
2+
3+
import static org.assertj.core.api.Assertions.assertThat;
4+
5+
import org.junit.jupiter.api.Test;
6+
import org.openapitools.openapidiff.core.model.ChangedOpenApi;
7+
import org.openapitools.openapidiff.core.output.ConsoleRender;
8+
9+
class AdditionalPropertiesTest {
10+
@Test
11+
void booleanAdditionalPropertiesAreSupported() {
12+
ChangedOpenApi diff = OpenApiCompare.fromLocations("issue-256_1.json", "issue-256_2.json");
13+
ConsoleRender render = new ConsoleRender();
14+
assertThat(render.render(diff)).isNotBlank();
15+
}
16+
}

0 commit comments

Comments
 (0)