Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Possibility to have currently not available values in the SERVER_* environment variables #2337

Closed
ioqy opened this issue Jun 27, 2024 · 5 comments · Fixed by #2419

Comments

@ioqy
Copy link

ioqy commented Jun 27, 2024

What's the feature 🧐

Allow invalid values in the following environment variables so that it's possible to have a list of preferred values and if a value is not found in the servers.json it is just ignored and another value is used.

  • SERVER_COUNTRIES
  • SERVER_REGIONS
  • SERVER_CITIES
  • SERVER_NAMES
  • SERVER_HOSTNAMES
  • ISP

Extra information and references

Background to my problem:

On multiple occasions I had the problem with AirVPN that servers where missing from the servers.json file and the gluetun would hang in a restart loop and could not establish a connection even though the server where listed on their websites. In the past the reason for this was that the country only had one server and it was temporarily offline. Today it was a region with multiple servers that was just missing from the servers.json even though it was listed on the website.

Copy link
Contributor

@qdm12 is more or less the only maintainer of this project and works on it in his free time.
Please:

@qdm12 qdm12 added Status: 🔒 After next release Will be done after the next release Complexity: ☣️ Hard to do Category: Good idea 🎯 This is a good idea, judged by the maintainers labels Jun 29, 2024
@qdm12
Copy link
Owner

qdm12 commented Aug 16, 2024

Please see #2419 and try image qmcgaw/gluetun:pr-2419 to check it fits your needs?

@ioqy
Copy link
Author

ioqy commented Aug 17, 2024

Yes, works great.

Thanks for the quick implementation.

Copy link
Contributor

Closed issues are NOT monitored, so commenting here is likely to be not seen.
If you think this is still unresolved and have more information to bring, please create another issue.

This is an automated comment setup because @qdm12 is the sole maintainer of this project
which became too popular to monitor issues closed.

1 similar comment
Copy link
Contributor

Closed issues are NOT monitored, so commenting here is likely to be not seen.
If you think this is still unresolved and have more information to bring, please create another issue.

This is an automated comment setup because @qdm12 is the sole maintainer of this project
which became too popular to monitor issues closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants