RSS Downloader starts downloading based on rules still being edited

[Belove0]

qBittorrent 3.0.9

Primary issue:
If you open the RSS Downloader and leave the default option of having RSS Downloading enabled, and then create a new rule, soon after you start typing characters in the "filter" field that match torrents in selected feeds, they start downloading.

In my case, about 1600 downloads where added in a keystroke, which brought QBt to a near halt.

I waited about 20 minutes before killing the process, as the GUI was nonfunctional, and then renamed qbittorrent-rss.ini

This successfully got rid of my partially entered download rules (I think that's what it did) and marked all the feeds unread.

However, it still took a very long time for QBt to startup up and the GUI to respond, having leapt from 200 active torrents to about 2000. I had queuing disabled, as per the default.

Secondary issues:
Furthermore, data on all my previous 200 torrents was corrupted. (1) They're save path was all changed to the default save path (which was generally incorrect, and resulted in redownloads of those torrents starting in the default save path). (2) Their labels where all removed, (everything was now unlabeled) (3) the start date/time for all torrents was reset to the present time (4) Completed on was reset/cleared (5) time active and bytes up/down were, however, preserved. (6) so far from what I can tell folder and file renames in the torrents were preserved, although under the wrong save path as already mentioned in [1].

Expectation:
In my opinion, three things: (A) the filter should not even be applied as you type, as the filter itself may be time consuming; wait til the user leaves that field or add a "test filter"-type button (B) New filters should not be applied until the user closes the RSS Downloader dialog. (C) Whatever caused the corruption of save data/other data for all my other torrents should be corrected :) -- perhaps it is simply a matter of 2000 active torrents not being fully supported, in which case it should not be possible to add 2000 torrents by any means. (with some kind of warnings that you can't add any more torrents or something, and that your RSS rules can't be fully applied).

This took a couple hours. QBt is now out of commission, but I will take another few hours when I can to correct everything.

Despite the occasional frustration, I like QBt and Thank you for your work on this project.

[Belove0]

Can anyone confirm whether this happens for them?
Just stay in the RSS Downloader dialog for at least the number of minutes between refreshes (edit: may or may not be necessary). I'd like to identify (before too much time passes and I forget) whether there are additional details about what I did that caused this to happen for me.

The effects were big, and as such I have to stay away from the RSS downlaoder feature. Still haven't finished getting my files and torrents all sorted yet.
Thanks :)

[Gelmir]

Confirming

1. Enable RSS Downloader and create a rule, which will match 1 item
2. Set Feed Update Interval to 1 min
3. Open RSS downloader and change rule to .* (regexp)
4. Wait 1 min

[sledgehammer999]

Also something I noticed today while randomly poking at the UI. The fix maybe identical for the 2 bugs:

1. Add an RSS feed
2. Create a new download rule(with *), check the above feed and wait "Matching RSS articles" to be populated BUT don't click the "Close" button.
3. Uncheck the above feed from the rule you just created and click "Close"
4. Notice that all torrents from that feed are added to the session, although you unchecked the feed from the rule.

[Gelmir]

I'm getting a fix for this soon ^™️
Solution is not very elegant. I had to make another class to store temporal RssDownloadRuleList data.

[Belove0]

Looks > trivial; appreciated!
Anything that works without the potential for unexpected massive destruction greatly reduces the priority of other improvements that could be made. Super-duper as far as I'm concerned. P.S. I am assuming that the "bing" reference does not relate to transmitting data to Microsft :)

[Belove0]

@Gelmir - One question: with temporal data in place, would it be easy enough (or have you already) included an option to cancel the dialog? Save/Cancel buttons, for instance, instead of Close?

[Gelmir]

Yeah. It should be easy enough. I might get to it eventually.

[sledgehammer999]

Fix merge into git. I will backport to 3.0.x for 3.0.10.