Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon is outside of viewport when opening DMG on mac #19802

Closed
Maxim-Mazurok opened this issue Oct 27, 2023 · 7 comments
Closed

Icon is outside of viewport when opening DMG on mac #19802

Maxim-Mazurok opened this issue Oct 27, 2023 · 7 comments
Labels
Build system Issue with the build configuration or scripts (but not the code itself) OS: macOS Issues specific to macOS

Comments

@Maxim-Mazurok
Copy link

qBittorrent & operating system versions

qBittorrent: 4.6.0 x64
Operating system: Mac OS 13.5.2 (22G91)

What is the problem?

As you can see, when I open DMG - icon is all the way at the bottom and I can't see if at first until I figured out to scroll.
This is a regression compared to the previous version, in which icon was right next to the Application folder icon, to the right.

Screenshot 2023-10-28 at 12 11 18 am

Steps to reproduce

download qBittorrent Mac OS X and open it

Additional context

MacBook Air Retina, 13-inch, 2019 - Default scaling

Log(s) & preferences file(s)

No response

@thalieht thalieht added the OS: macOS Issues specific to macOS label Oct 27, 2023
@luzpaz
Copy link
Contributor

luzpaz commented Oct 27, 2023

Weird, can anyone confirm? And if so, what is the fix ?

@timonsku
Copy link

I had this too with the 4.6 update. I did not realize it was just out of view and went into finder instead to drag it into Applications.
I took a look again, when I enable hidden files it seems to maybe relate to the position of that hidden .Volume.icns file.
Maybe some behaviour in the settings for icon positions for the dmg changed.

image

@timonsku
Copy link

Looks like this is determined by the .DS_Store file
In 4.5.2 dmg:

Layout property list:
                ShowStatusBar: False
                ShowTabView: False
                ContainerShowSidebar: False
                WindowBounds: {{10, 821}, {800, 400}}
                ShowSidebar: False
        Icon view property list:
                backgroundColorBlue: 1.0
                gridSpacing: 100.0
                textSize: 16.0
                backgroundColorRed: 1.0
                backgroundType: 0
                backgroundColorGreen: 1.0
                gridOffsetX: 0.0
                gridOffsetY: 0.0
                showItemInfo: False
                viewOptionsVersion: 1
                labelOnBottom: True
                arrangeBy: none
                iconSize: 128.0
                showIconPreview: True
        vSrn (unknown): 1
.fseventsd
        Icon location: x 114px, y 82px, 0xffffffffffff0000
.VolumeIcon.icns
        Icon location: x 450px, y 82px, 0xffffffffffff0000
Applications
        Icon location: x 280px, y 165px, 0xffffffffffff0000
qbittorrent.app
        Icon location: x 618px, y 82px, 0xffffffffffff0000

In 4.6.2:

        Layout property list:
                ShowStatusBar: False
                ShowToolbar: False
                ShowTabView: False
                ContainerShowSidebar: False
                WindowBounds: {{10, 533}, {800, 400}}
                ShowSidebar: False
        Icon view property list:
                backgroundColorBlue: 1.0
                showIconPreview: True
                textSize: 16.0
                backgroundColorRed: 1.0
                backgroundType: 0
                backgroundColorGreen: 1.0
                gridOffsetX: 0.0
                gridOffsetY: 0.0
                showItemInfo: False
                viewOptionsVersion: 1
                arrangeBy: none
                labelOnBottom: True
                iconSize: 128.0
                gridSpacing: 100.0
.fseventsd
        Icon location: x 530px, y 82px, 0xffffffffffff0000
.VolumeIcon.icns
        Icon location: x 530px, y 272px, 0xffffffffffff0000
Applications
        Icon location: x 260px, y 120px, 0xffffffffffffffff
qbittorrent.app
        Icon location: x 114px, y 462px, 0xffffffffffff0000

Not sure where this comes from in the build but either setting the x y coordinates differently or setting the folder view to be grouped by names fixes this as seen below:
image

@timonsku
Copy link

https://github.com/dmgbuild/dmgbuild lets you define these things. Doesn't look like the currently used macdeployqt has any options there. It seems by default it just uses the DS_store from the active directory for the resulting dmg. So maybe placing a prepared DS_store in the working directory would be a quick fix. I don't have the setup to test this outside of the github CI though.

@luzpaz luzpaz added the Build system Issue with the build configuration or scripts (but not the code itself) label Nov 5, 2023
@Maxim-Mazurok
Copy link
Author

The issue is resolved in v4.6.1:
Screenshot 2023-11-25 at 12 57 47 am
Thanks!

@glassez
Copy link
Member

glassez commented Nov 24, 2023

Offtopic:
@Maxim-Mazurok, don't you have a problem like #19986 with v4.6.1?

@Maxim-Mazurok
Copy link
Author

Offtopic:
@Maxim-Mazurok, don't you have a problem like #19986 with v4.6.1?

I have torrents from the downloads folder to be automatically added, so I didn't notice, will check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build system Issue with the build configuration or scripts (but not the code itself) OS: macOS Issues specific to macOS
Projects
None yet
Development

No branches or pull requests

5 participants