Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matched RSS articles not downloading when Rule set to Download #18875

Open
ghost opened this issue Apr 21, 2023 · 17 comments
Open

Matched RSS articles not downloading when Rule set to Download #18875

ghost opened this issue Apr 21, 2023 · 17 comments
Labels
RSS RSS-related issues/changes

Comments

@ghost
Copy link

ghost commented Apr 21, 2023

qBittorrent & operating system versions

macOS 12.6.5
v4.5.2 (64-bit)
Qt: 6.4.2
Libtorrent: 1.2.18.0
Boost: 1.81.0
OpenSSL: 1.1.1t
zlib: 1.2.11

What is the problem?

Rules created in RSS Downloader are not obeying the Rule Definition option Add Paused: Never i.e. download when matched

Additional context

A matched article has appeared in the Matching RSS Articles column per my regex string.
The Rule Definition is set to Add Paused: Never

Ignore Subsequent Matches is set to Disabled
Last Match shows Unknown - I would expect it to show the date of the current matching article…

I haven't tested this but I am thinking the cause is my current setting in preferences Do not start the download automatically checked, as conflicting/overriding the Rule Definition... but should it? My perception was the option in the Rule Definition would override the setting in Downloads > When adding a torrent > Do not start the download automatically

If choosing an option in Rule Definition has no effect one would presume the field would be locked to Paused and greyed out if the rule definition is always overridden by Do not start the download automatically setting in preferences.

My rule

"movie - Enys Men 2022": {
        "addPaused": false,
        "affectedFeeds": [
            "http://127.0.0.1:9117/api/v2.0/indexers/rarbg/results/torznab/api?apikey=redacted&t=search&cat=100054&q="
        ],
        "assignedCategory": "Movie",
        "enabled": true,
        "episodeFilter": "",
        "ignoreDays": 0,
        "lastMatch": "",
        "mustContain": "(?i)(^Enys.Men).*(WEB|BluRay)",
        "mustNotContain": "",
        "previouslyMatchedEpisodes": [
        ],
        "savePath": "",
        "smartFilter": false,
        "torrentContentLayout": null,
        "useRegex": true
    }

Log(s) & preferences file(s)

No response

@ghost ghost changed the title Matched RSS articles not downloading Matched RSS articles not downloading when Rule set to Download Apr 21, 2023
@thalieht thalieht added the RSS RSS-related issues/changes label Apr 21, 2023
@glassez
Copy link
Member

glassez commented Apr 21, 2023

My perception was the option in the Rule Definition would override the setting in Downloads > When adding a torrent > Do not start the download automatically

Yes, it is intended.
But do you really say that matched torrents are added in "Paused" state despite "Add Paused: Never"?

@ghost
Copy link
Author

ghost commented Apr 21, 2023

Yes, it is intended.
But do you really say that matched torrents are added in "Paused" state despite "Add Paused: Never"?

Have to backtrack I went down the wrong path. I am just realizing there is a precedence issue.

In this case I have two RSS rules that both matched the same Article. One asked matching Articles to be added in a Paused state the other to Never be added in a paused state. It looks like Paused state won.

The Feed
http://127.0.0.1:9117/api/v2.0/indexers/rarbg/results/torznab/api?apikey=redacted&t=search&cat=100054&q=

One rule matches many articles in an RSS feed for me to peruse in a paused state:

"M1 RARBG (matched)": {
        "addPaused": true,
        "affectedFeeds": [
            "http://127.0.0.1:9117/api/v2.0/indexers/rarbg/results/torznab/api?apikey=redacted&t=search&cat=100054&q=",
            "http://127.0.0.1:9117/api/v2.0/indexers/rarbg/results/torznab/api?apikey=redacted&t=search&cat=100052&q="
        ],
        "assignedCategory": "Movie (RSS matched)",
        "enabled": true,
        "episodeFilter": "",
        "ignoreDays": 0,
        "lastMatch": "21 Apr 2023 13:50:27 +0000",
        "mustContain": "(?:198|2022|2023)",
        "mustNotContain": "(Christmas)|(\\b7.1)|(\\b.DV.\\b)|(DTS-HD.MA)",
        "previouslyMatchedEpisodes": [
        ],
        "savePath": "",
        "smartFilter": false,
        "torrentContentLayout": null,
        "useRegex": true
    }

The other matches a single articles and this article happened to be in the subset of the first rule as well.

    "movie - Enys Men 2022": {
        "addPaused": false,
        "affectedFeeds": [
            "http://127.0.0.1:9117/api/v2.0/indexers/rarbg/results/torznab/api?apikey=redacted&t=search&cat=100054&q="
        ],
        "assignedCategory": "Movie",
        "enabled": true,
        "episodeFilter": "",
        "ignoreDays": 0,
        "lastMatch": "",
        "mustContain": "(?i)(^Enys.Men).*(WEB|BluRay)",
        "mustNotContain": "",
        "previouslyMatchedEpisodes": [
        ],
        "savePath": "",
        "smartFilter": false,
        "torrentContentLayout": null,
        "useRegex": true
    }

In this case it looks like the program favors Paused state over Never add Paused - is this intentional or just coincidence?

@glassez
Copy link
Member

glassez commented Apr 22, 2023

In this case it looks like the program favors Paused state over Never add Paused - is this intentional or just coincidence?

The rule that was applied first is used.

@ghost
Copy link
Author

ghost commented May 9, 2023

The rule that was applied first is used.

I presume I can change the order they run by renaming the rules... prefixing with a numeral?

@glassez
Copy link
Member

glassez commented May 10, 2023

I presume I can change the order they run by renaming the rules... prefixing with a numeral?

Rules aren't ordered by name while processing.

@ghost
Copy link
Author

ghost commented May 10, 2023

I presume I can change the order they run by renaming the rules... prefixing with a numeral?

Rules aren't ordered by name while processing.

OK. I was asking how can I control which rule runs first?

@glassez
Copy link
Member

glassez commented May 10, 2023

OK. I was asking how can I control which rule runs first?

No way. Apparently, it was assumed that it was the user's responsibility to make sure that the rules did not overlap.

@ghost
Copy link
Author

ghost commented May 10, 2023

OK. I was asking how can I control which rule runs first?

No way. Apparently, it was assumed that it was the user's responsibility to make sure that the rules did not overlap.

I love humor as much as the next guy AND there is a real use case from my perspective.

  1. I have specific named files I want to automatically download using RSS rules for feed A
  2. I also have an RSS rule that tracks every uploaded file on feed A which I peruse manually... don't want to miss something good.

I don't want to invalidate the first in order to have the second option. Is there another method you can think of that will accomplish this ?

If the rules were run based on their sequence of entry in the .json file (by line number) then it's easy enough to just sort that alphanumerically and re-import that back into qBt making sure the catch all rules are at the end.

Also, I want to thank you for the updated RSS in the current master. Loving the new Tag feature I put a bounty on.

@glassez
Copy link
Member

glassez commented May 10, 2023

In fact, it looks easy to change it so that the rules are applied in alphabetical order. However, alphabetical order does not look like a general solution claiming to be convenient, since it requires distorting the names of the rules by introducing some third-party information there. But it could still be a suitable compromise anyway.

@glassez

This comment was marked as off-topic.

@ghost
Copy link
Author

ghost commented May 10, 2023

... since it requires distorting the names of the rules by introducing some third-party information there.

Are you referring to "RSS feeds" or "RSS Downloader - Download Rules"?

The Download Rules are named manually by the user. No predefined text is entered.

I name my rules intentionally to group them by category so I can locate and edit or remove them when they've fired.

book - name of book
movie - name of movie
series - name of series
_book - all items
_movie - all items
_series - all items

It's not too complicated. As long as they are all the same case and not mixed (upper, lower, title case) they are listed in alphabetical order. I can add alphanumerics to change a Rules position as well.

Re: #13917(comment)
I didn't know who would accept and what form of payment they prefer. I understand it's not possible for you to get PayPal payments at this time... yet you did the bulk of the work. It's a conundrum as I have never created a crypto account and unfortunately I can't get my money back from bountysource to change the form of payment. If I can figure out a way to donate it to the project instead maybe they could pay you via crypto? Ideas?

@glassez
Copy link
Member

glassez commented May 21, 2023

I can add alphanumerics to change a Rules position as well.

I still prefer to use separate property to affect order of rules.
#19000

@ghost
Copy link
Author

ghost commented May 27, 2023

I added a comment to #19000

@xavier2k6
Copy link
Member

@glassez OP is gone....Does #19000 fully close this issue?

@glassez
Copy link
Member

glassez commented Sep 10, 2023

@glassez OP is gone....Does #19000 fully close this issue?

It was a slightly subjective issue, IMO, so I don't really know. I have only provided an additional tool that could contribute to its resolving.

@xavier2k6
Copy link
Member

@glassez Ok, Thanks - I will leave it open for now.

@luzpaz
Copy link
Contributor

luzpaz commented Sep 18, 2023

Can we delineate what is left then to do ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RSS RSS-related issues/changes
Projects
None yet
Development

No branches or pull requests

4 participants