Security permissions not inherited when files are moved from Incomplete folder

[mschumacher69]

Please provide the following information

qBittorrent version and Operating System

qB v4.2.5 Windows 7 (6.1.760x)

If on linux, libtorrent-rasterbar and Qt version

(type here)

What is the problem

When "Keep incomplete torrents in" is selected under Settings > Downloads, files that get moved to their destination folder once completed are not inheriting the security permissions from the destination folder, they are maintaining the security permissions from the source (incomplete) folder.

What is the expected behavior

Files moved to their destination folder should inherit security permissions from the destination folder once moved after they're complete.

Steps to reproduce

1. Enable "Keep incomplete torrents in" and select a folder which has different security permissions than the actual destination folder (add the Guest account to the destination folder permissions for example).
2. Download a torrent, it starts downloading in the incomplete folder which doesn't have the Guest security permissions. Once it completes, the files are moved to the destination folder which has the Guest security permissions.
3. Check the permissions on the complete files, they wouldn't have the Guest security permissions even though they should inherit it from the destination folder which does have it.

Extra info(if any)

(type here)

[mschumacher69]

@FranciscoPombal does the OS: Windows label mean the issue is with Windows not with qB?

[FranciscoPombal]

@mschumacher69 no, it means it is potentially related to something Windows specific. Skimming through your post, I understood that it has to do with Windows permissions, so I thought it might have to do with a problem qBittorrent has with that. The actual root of the problem could be from qBittorrent's internal logic, Qt, ... someone still has to attempt to reproduce it figure it out.

[mschumacher69]

Thanks. I can help you troubleshoot if you want. What I noticed is that the "Include inheritable permissions from this object's parent" would be checked on the files after they're moved (as expected) but the files wouldn't inherit the permissions for some reason until I uncheck and recheck this setting.

[FranciscoPombal]

I don't use Windows as my daily driver, or much at all. But @xavier2k6 could probably lend a hand.

[mschumacher69]

@xavier2k6 did you manage to replicate this?

[xavier2k6]

@mschumacher69 @FranciscoPombal apologies - totally missed this. Unfortunately I don't have to time to fully look in to this currently.

[ATGardner]

I just encountered a bug with similar outcomes -
If I download my torrents to folder A, which has no special permissions, and then use the set location option (I think it has a different label during the download, but it has the same meaning), and move it to folder B, which has special permissions (like you suggest - Guest access - for example), the downloaded files do not have the new permission.
If I set my download location to folder B from the start, the permissions are set correctly.

So it seems as though the issue is with the "move" logic of qbittorrent (that's my guess, at least).

[h3llrais3r]

Any workaround for this? Facing the same issue that after move the file permissions of the location are not inherited...
The subfolders are inheriting the permissions of folder it's moved to (read access for everyone), but the files inside are missing the permissions (read access for everyone).