Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the "check for updates" menu entry an icon. #10110

Closed
ghost opened this issue Jan 4, 2019 · 9 comments
Closed

Give the "check for updates" menu entry an icon. #10110

ghost opened this issue Jan 4, 2019 · 9 comments
Labels
Feature request GUI GUI-related issues/changes Look and feel Affect UI "Look and feel" only without changing the logic

Comments

@ghost
Copy link

ghost commented Jan 4, 2019

For the sake of keeping qBittorrent's menus consistent and filled with visual cues, there should be an icon for Help > Check for Updates.

Here's a screenshot to show what I'm asking for, with @bertyhell proposing an icon, but the issue is that there's currently no icon linked to that menu option at all. I'm sure many people will agree that while this request is minor, it adds to the visual style of qBittorrent.

update

@FranciscoPombal FranciscoPombal changed the title UI Feature Request: Give the "check for updates" menu entry an icon. Give the "check for updates" menu entry an icon. Sep 14, 2020
@FranciscoPombal FranciscoPombal added Feature request GUI GUI-related issues/changes labels Sep 14, 2020
@xavier2k6
Copy link
Member

xavier2k6 commented Mar 10, 2021

@sledgehammer999 Are you still against this?

Previous view-refresh icon could be used OR the check-updates icon could be added to maintain colour scheme

Screenshot 2021-03-10 134955

Modifications to \src\gui\mainwindow.cpp

m_ui->actionCheckForUpdates->setIcon(UIThemeManager::instance()->getIcon("view-refresh"));

or

m_ui->actionCheckForUpdates->setIcon(UIThemeManager::instance()->getIcon("check-updates"));

(Also requires check-updates icon to be added to icons.qrc file)

@Mazino-Urek
Copy link
Contributor

Modifications to \src\gui\mainwindow.cpp

m_ui->actionCheckForUpdates->setIcon(UIThemeManager::instance()->getIcon("view-refresh"));

Which line do I modify or add?

@Mazino-Urek
Copy link
Contributor

Mazino-Urek commented Sep 14, 2021

@xavier2k6 View-refresh icon or this?
image

@xavier2k6
Copy link
Member

View-refresh icon or this?

No real preference but if you go with the different icon make sure you name it check-updates or something...

Which line do I modify or add?

File that needs to be "modified" is \src\gui\mainwindow.cpp

You add below in full if going with view-refresh
m_ui->actionCheckForUpdates->setIcon(UIThemeManager::instance()->getIcon("view-refresh"));

or

You add below in full if going with check-updates
m_ui->actionCheckForUpdates->setIcon(UIThemeManager::instance()->getIcon("check-updates"));

Reference:

addToolbarContextMenu();
m_ui->actionOpen->setIcon(UIThemeManager::instance()->getIcon("list-add"));
m_ui->actionDownloadFromURL->setIcon(UIThemeManager::instance()->getIcon("insert-link"));
m_ui->actionSetGlobalSpeedLimits->setIcon(UIThemeManager::instance()->getIcon("speedometer"));
m_ui->actionCreateTorrent->setIcon(UIThemeManager::instance()->getIcon("document-edit"));
m_ui->actionAbout->setIcon(UIThemeManager::instance()->getIcon("help-about"));
m_ui->actionStatistics->setIcon(UIThemeManager::instance()->getIcon("view-statistics"));
m_ui->actionTopQueuePos->setIcon(UIThemeManager::instance()->getIcon("go-top"));
m_ui->actionIncreaseQueuePos->setIcon(UIThemeManager::instance()->getIcon("go-up"));
m_ui->actionDecreaseQueuePos->setIcon(UIThemeManager::instance()->getIcon("go-down"));
m_ui->actionBottomQueuePos->setIcon(UIThemeManager::instance()->getIcon("go-bottom"));
m_ui->actionDelete->setIcon(UIThemeManager::instance()->getIcon("list-remove"));
m_ui->actionDocumentation->setIcon(UIThemeManager::instance()->getIcon("help-contents"));
m_ui->actionDonateMoney->setIcon(UIThemeManager::instance()->getIcon("wallet-open"));
m_ui->actionExit->setIcon(UIThemeManager::instance()->getIcon("application-exit"));
m_ui->actionLock->setIcon(UIThemeManager::instance()->getIcon("object-locked"));
m_ui->actionOptions->setIcon(UIThemeManager::instance()->getIcon("configure", "preferences-system"));
m_ui->actionPause->setIcon(UIThemeManager::instance()->getIcon("media-playback-pause"));
m_ui->actionPauseAll->setIcon(UIThemeManager::instance()->getIcon("media-playback-pause"));
m_ui->actionStart->setIcon(UIThemeManager::instance()->getIcon("media-playback-start"));
m_ui->actionStartAll->setIcon(UIThemeManager::instance()->getIcon("media-playback-start"));
m_ui->menuAutoShutdownOnDownloadsCompletion->setIcon(UIThemeManager::instance()->getIcon("application-exit"));
m_ui->actionManageCookies->setIcon(UIThemeManager::instance()->getIcon("preferences-web-browser-cookies"));

@bertyhell
Copy link
Contributor

most of the icons are currently based on fontawesome. So i propose to use this icon: https://fontawesome.com/v5.15/icons/sync-alt?style=solid

@xavier2k6
Copy link
Member

xavier2k6 commented Sep 14, 2021

most of the icons are currently based on fontawesome. So i propose to use this icon: https://fontawesome.com/v5.15/icons/sync-alt?style=solid

@bertyhell icons are being changed reference PR #15453

@Mazino-Urek
Copy link
Contributor

@xavier2k6 I have linked view-refresh, as it is directly indicates its job.

@bertyhell
Copy link
Contributor

ah, ok, yeah that one is perfect :)

@thalieht thalieht added the Look and feel Affect UI "Look and feel" only without changing the logic label Aug 7, 2022
@xavier2k6
Copy link
Member

Implemented in #15769 & will be included in 4.5.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request GUI GUI-related issues/changes Look and feel Affect UI "Look and feel" only without changing the logic
Projects
None yet
Development

No branches or pull requests

6 participants