changed simple expects to poll expects (#90)

* changed simple expects to poll expects
* replaced _playwrightValueWait_ type with more generic _playwrightValidation_ allowing more wait types

Author: AlexGalichenko

.github/workflows/pull-request.yml

@@ -9,7 +9,7 @@ jobs:
   test:
     strategy:
       matrix:
-        version: [ 18, 20, 21 ]
+        version: [ 18, 20 ]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3

CHANGELOG.md

@@ -8,6 +8,11 @@ Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how
 :beetle: - bugfix
 :x: - deprecation
 
+## [0.40.0]
+- :rocket: changed simple expects to poll expects
+- :rocket: replaced _wdioValueWait_ type with more generic _wdioValidation_ allowing more wait types
+  Breaking change: value waits now depends on _value_ timeout
+
 ## [0.39.0]
 - :rocket: enabled logger for page objects
 

README.md

@@ -19,7 +19,9 @@ module.exports = {
             timeout: {
                 present: 10000,
                 visible: 20000,
-                page: 10000
+                page: 10000,
+                value: 5000, // expect value timeout
+                valueInterval: 500 //expect value interval
             },
             capabilities: {
                 browserName: 'chromium'

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@qavajs/steps-playwright",
-  "version": "0.39.0",
+  "version": "0.40.0",
   "description": "steps to interact with playwright",
   "main": "./index.js",
   "scripts": {
@@ -30,20 +30,20 @@
     "@qavajs/console-formatter": "^0.6.0",
     "@qavajs/html-formatter": "^0.15.2",
     "@qavajs/memory": "^1.6.2",
-    "@qavajs/po-playwright": "^0.11.3",
+    "@qavajs/po-playwright": "^0.12.0",
     "@qavajs/webstorm-adapter": "^8.0.0",
-    "@types/chai": "^4.3.10",
+    "@types/chai": "^4.3.11",
     "@types/express": "^4.17.21",
     "@vitest/coverage-v8": "^0.34.6",
-    "electron": "^27.1.0",
+    "electron": "^27.1.2",
     "express": "^4.18.2",
     "ts-node": "^10.9.1",
-    "typescript": "^5.2.2",
+    "typescript": "^5.3.2",
     "vitest": "^0.34.6"
   },
   "dependencies": {
     "@playwright/test": "^1.40.0",
-    "@qavajs/validation": "^0.6.0",
+    "@qavajs/validation": "^0.7.0",
     "playwright": "^1.40.0"
   }
 }

package.json

@@ -1,5 +1,7 @@
 export default {
     present: 10000,
     visible: 10000,
-    page: 10000
+    page: 10000,
+    value: 5000,
+    valueInterval: 500
 }

src/defaultTimeouts.ts

@@ -37,7 +37,7 @@ BeforeAll(async function () {
     await createJSEngine();
 });
 
-Before(async function () {
+Before({name: 'context init'}, async function () {
     const driverConfig = config.browser ?? config.driver;
     driverConfig.isElectron = driverConfig.capabilities.browserName === 'electron';
     driverConfig.timeout = {
@@ -89,7 +89,7 @@ AfterStep(async function (step: ITestStepHookParameter) {
     }
 });
 
-After(async function (scenario: ITestCaseHookParameter) {
+After({name: 'context teardown'}, async function (scenario: ITestCaseHookParameter) {
     if (saveTrace(config.driverConfig, scenario)) {
         const path = traceArchive(config.driverConfig, scenario);
         await context.tracing.stop({ path });

src/hooks.ts

@@ -1,5 +1,4 @@
 import { conditionWait, conditionWaitExtractRegexp } from './conditionWait';
-import { valueWait, valueWaitExtractRegexp } from './valueWait';
 import { po } from '@qavajs/po-playwright';
 import memory from '@qavajs/memory';
 import { Locator } from 'playwright';
@@ -20,12 +19,3 @@ export function getConditionWait(condition: string): Function {
         await conditionWait(element, validation, timeout, Boolean(reverse))
     }
 }
-
-export function getValueWait(condition: string): Function {
-    const match = condition.match(valueWaitExtractRegexp) as RegExpMatchArray;
-    if (!match) throw new Error(`${condition} wait is not implemented`);
-    const [ _, reverse, validation ] = match;
-    return async function (valueFn: Function, expected: any, timeout: number) {
-        await valueWait(valueFn, expected, validation, timeout, Boolean(reverse))
-    }
-}