make params in hooks closer to cucumber types (#16)

Author: AlexGalichenko

CHANGELOG.md

@@ -10,6 +10,9 @@ Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how
 :pencil: - chore
 :microscope: - experimental
 
+## [0.6.1]
+- :beetle: make params in hooks closer to cucumber types
+
 ## [0.6.0]
 - :rocket: added test case accessor to BeforeStep/AfterStep hooks
 

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@qavajs/playwright-runner-adapter",
-  "version": "0.6.0",
+  "version": "0.6.1",
   "description": "adapter for playwright test runner",
   "scripts": {
     "build": "tsc",

package.json

@@ -38,15 +38,20 @@ for (const feature of features) {
                 for (const beforeHook of supportCodeLibrary.beforeTestCaseHookDefinitions) {
                     if (beforeHook.appliesToTestCase(testCase)) {
                         await test.step('Before', async () => {
-                            await beforeHook.code.apply(world, [testCase]);
+                            await beforeHook.code.apply(world, [{
+                                pickle: testCase
+                            }]);
                         });
                     }
                 }
                 for (const pickleStep of testCase.steps) {
                     await test.step(pickleStep.text, async () => {
                         for (const beforeStep of supportCodeLibrary.beforeTestStepHookDefinitions) {
                             if (beforeStep.appliesToTestCase(testCase)) {
-                                await beforeStep.code.apply(world, [testCase]);
+                                await beforeStep.code.apply(world, [{
+                                    pickle: testCase,
+                                    pickleStep
+                                }]);
                             }
                         }
                         const steps = supportCodeLibrary.stepDefinitions
@@ -69,7 +74,11 @@ for (const feature of features) {
                         }
                         for (const afterStep of supportCodeLibrary.afterTestStepHookDefinitions) {
                             if (afterStep.appliesToTestCase(testCase)) {
-                                await afterStep.code.apply(world, [{...testCase, result}]);
+                                await afterStep.code.apply(world, [{
+                                    pickle: testCase,
+                                    pickleStep,
+                                    result
+                                }]);
                             }
                         }
                         if (result.error) throw result.error;
@@ -78,7 +87,9 @@ for (const feature of features) {
                 for (const afterHook of supportCodeLibrary.afterTestCaseHookDefinitions) {
                     if (afterHook.appliesToTestCase(testCase)) {
                         await test.step('After', async () => {
-                            await afterHook.code.apply(world, [{...testCase, result}]);
+                            await afterHook.code.apply(world, [{
+                                pickle: testCase, result
+                            }]);
                         });
                     }
                 }

src/adapter.spec.ts

@@ -1,4 +1,14 @@
-import { Given, When, setWorldConstructor, DataTable, Before, After, BeforeStep, AfterStep } from '@cucumber/cucumber';
+import {
+    Given,
+    When,
+    setWorldConstructor,
+    DataTable,
+    Before,
+    After,
+    BeforeStep,
+    AfterStep,
+    ITestCaseHookParameter, ITestStepHookParameter
+} from '@cucumber/cucumber';
 import { test as base, expect as baseExpect, Page, Locator } from '@playwright/test';
 import { PlaywrightWorld } from '../../src/PlaywrightWorld';
 
@@ -69,20 +79,22 @@ When('custom expect', async function (this: ExtendedPlaywrightWorld) {
     this.expect(this.page.locator('body')).toAlwaysPass();
 });
 
-Before(async function (this: ExtendedPlaywrightWorld, testCase) {
-    this.expect(testCase).toBeTruthy();
+Before(async function (this: ExtendedPlaywrightWorld, testCase: ITestCaseHookParameter) {
+    this.expect(testCase.pickle).toBeTruthy();
 });
 
-After(async function (this: ExtendedPlaywrightWorld, testCase) {
-    this.expect(testCase).toBeTruthy();
+After(async function (this: ExtendedPlaywrightWorld, testCase: ITestCaseHookParameter) {
+    this.expect(testCase.pickle).toBeTruthy();
     this.expect(testCase.result).toBeTruthy();
 });
 
-BeforeStep(async function (this: ExtendedPlaywrightWorld, testCase) {
-    this.expect(testCase).toBeTruthy();
+BeforeStep(async function (this: ExtendedPlaywrightWorld, testCase: ITestStepHookParameter) {
+    this.expect(testCase.pickle).toBeTruthy();
+    this.expect(testCase.pickleStep).toBeTruthy();
 });
 
-AfterStep(async function (this: ExtendedPlaywrightWorld, testCase) {
-    this.expect(testCase).toBeTruthy();
+AfterStep(async function (this: ExtendedPlaywrightWorld, testCase: ITestStepHookParameter) {
+    this.expect(testCase.pickle).toBeTruthy();
+    this.expect(testCase.pickleStep).toBeTruthy();
     this.expect(testCase.result).toBeTruthy();
 });