Fix deprecations

.renovaterc.json

@@ -1,17 +1,17 @@
 {
-    "assignees": ["r-hannuschka"],
+    "assignees": [ "r-hannuschka" ],
     "automerge": false,
     "baseBranches": [
-      "development"
+        "development"
     ],
     "extends": [
-      "config:base"
+        "config:base"
     ],
     "packageRules": [
-      {
-        "groupName": "linters",
-        "packagePatterns": ["tslint", "prettier"]
-      }
+        {
+            "groupName": "linters",
+            "packagePatterns": [ "tslint", "prettier" ]
+        }
     ],
     "schedule": "before 10am",
     "timezone": "Europe/Berlin"

docs/cli.md

@@ -9,6 +9,6 @@ q2gb --init <extension|webpack> to start helper to create extension or webpack b
 
 to enable that feature it is required to install q2g-build as global package 
 
-npm i -g q2g-build
+npm i -g q2g-build-bak
 
 ![Qlik2Go CLI Demo](./images/q2gb-cli.gif)

src/README.md

@@ -2,7 +2,7 @@
 
 [![Codacy Badge](https://api.codacy.com/project/badge/Grade/48294aa49a3c4f2db610df9e2676ccfd)](https://app.codacy.com/app/konne/q2g-build?utm_source=github.com&utm_medium=referral&utm_content=q2g/q2g-build&utm_campaign=badger)
 
-Qlik2Go Build Process which contains multiple build proceses for Webpack and Typescript, maintainly used to build and deploy qlik extensions on qlik sense.
+Qlik2Go Build Process which contains multiple build processes for Webpack and Typescript, mainly used to build and deploy Qlik extensions on Qlik Sense.
 
 ## Usage
 
@@ -90,8 +90,8 @@ extension/index.css
 
 ### Use q2gb cli
 
-You can allways create all required configuration files by your own if you want, but we will use q2gb cli which helps us to create required configuration files.
-It also updates the package json and add required npm scripts to start build process (dev and prod), also qext file informations.
+You can always create all required configuration files by your own if you want, but we will use q2gb cli which helps us to create required configuration files.
+It also updates the package.json and adds required npm scripts to start the build process (dev and prod), also qext file information.
 
 ```bash
 C:\Users\rhannuschka\work\q2g-demo-extension>q2gb --init extension

src/builder/extension-builder/service/desktop.service.ts

@@ -4,14 +4,13 @@ import { isNullOrUndefined } from "util";
 import { IExtensionFile } from "../api/extensionFile.interface";
 
 export class DesktopService {
-
     public static get instance(): DesktopService {
         return DesktopService.desktopInstance;
     }
 
     private static desktopInstance: DesktopService = new DesktopService();
 
-    private defaultPath = `${homedir}\\Documents\\Qlik\\Sense\\Extensions\\`;
+    private defaultPath: string = `${homedir}\\Documents\\Qlik\\Sense\\Extensions\\`;
 
     public constructor() {
         if (DesktopService.desktopInstance) {
@@ -46,12 +45,11 @@ export class DesktopService {
     private writeFilePromise(path: string, file: string | Buffer): Promise<void> {
         return new Promise((resolveProm, reject) => {
             writeFile(path, file, (e) => {
-                if (!isNullOrUndefined(e)) {
+                if (!(e === null || e === undefined)) {
                     reject(e);
                 }
                 resolveProm();
             });
         });
     }
-
 }

src/builder/extension-builder/service/extension.service.ts

@@ -1,6 +1,5 @@
 import { readFileSync } from "fs";
 import { resolve } from "path";
-import { isArray } from "util";
 import { IDataNode } from "../../../api/data-node";
 import { IQextData } from "../../qext-file-builder/api";
 import { WebpackService } from "../../webpack-builder/service/webpack.service";
@@ -66,7 +65,7 @@ export class ExtensionService {
      */
     public async extensionExists(name: string): Promise<boolean> {
         const extensions = await this.qrsService.fetchExtension(name);
-        return isArray(extensions) && extensions.length > 0;
+        return Array.isArray(extensions) && extensions.length > 0;
     }
 
     public importExtension(name: string, file: Buffer) {

src/data/commandline.options.ts

@@ -10,7 +10,6 @@ export const CommandlineOptions: IOptionRuleSet  = {
    },
    env: {
        required: false,
-       validatorFn: ValidationHelper.containsValue(
-            ["development", "production"]),
+       validatorFn: ValidationHelper.containsValue(["development", "production"]),
    },
 };

src/lib/cli/commands/cow-say.command.ts

@@ -1,5 +1,3 @@
-import { isArray } from "util";
-
 export enum CowType {
     ERROR   = 0,
     DEFAULT = 1,
@@ -31,7 +29,7 @@ const errorCow = `
  */
 export function cowSay(message: string | string[], type: CowType = CowType.DEFAULT) {
 
-    if (!isArray(message)) {
+    if (!Array.isArray(message)) {
         message = [...message.split(/\n/)];
     }
 

src/lib/cli/model/webpack/webpack-properties.ts

@@ -1,5 +1,4 @@
 import { isAbsolute } from "path";
-import { isArray } from "util";
 import { ICommandLineBuilderData } from "../../api/cmdline-observer";
 import { Namespaces } from "../../api/namespaces";
 
@@ -9,7 +8,7 @@ export const WebpackProperties: ICommandLineBuilderData = {
             name: "entryFile",
             text: "Webpack$ entry file (relative path)",
             validator: (value): boolean => {
-                return !isAbsolute(value) && isArray(value.match(/^\.(?=\/)/));
+                return !isAbsolute(value) && Array.isArray(value.match(/^\.(?=\/)/));
             },
         },
         {
@@ -23,7 +22,7 @@ export const WebpackProperties: ICommandLineBuilderData = {
             name: "outputDirectory",
             text: "Webpack$ out directory (relative path)",
             validator: (value) => {
-                return !isAbsolute(value) && isArray(value.match(/^\.(?=\/)/));
+                return !isAbsolute(value) && Array.isArray(value.match(/^\.(?=\/)/));
             },
         },
         {

src/lib/cli/service/extension.ts

@@ -105,9 +105,9 @@ export class Extension extends Webpack {
      */
     protected writeBuildScripts(configFileName: string) {
         const scripts = {
-            "q2g-build:dev": `node node_modules/q2g-build --builder extension --config ${configFileName}`,
+            "q2g-build:dev": `node node_modules/q2g-build-bak --builder extension --config ${configFileName}`,
             // tslint:disable-next-line:max-line-length
-            "q2g-build:prod": `node node_modules/q2g-build --builder extension --env production --config ${configFileName}`,
+            "q2g-build:prod": `node node_modules/q2g-build-bak --builder extension --env production --config ${configFileName}`,
         };
         this.writer.write("scripts", scripts);
     }

src/lib/cli/service/webpack.ts

@@ -88,9 +88,9 @@ export class Webpack implements ICommandLineReaderObserver {
      */
     protected writeBuildScripts(configFileName: string) {
         const scripts = {
-            "q2g-build:dev": `node node_modules/q2g-build --builder webpack --config ${configFileName}`,
+            "q2g-build:dev": `node node_modules/q2g-build-bak --builder webpack --config ${configFileName}`,
             // tslint:disable-next-line:max-line-length
-            "q2g-build:prod": `node node_modules/q2g-build --builder webpack --env production --config ${configFileName}`,
+            "q2g-build:prod": `node node_modules/q2g-build-bak --builder webpack --env production --config ${configFileName}`,
         };
 
         this.pkgJsonWriter.write("scripts", scripts);

src/main.ts

@@ -19,7 +19,7 @@ function loadFromFile(configFile: string): IDataNode {
 
     if ( ! existsSync(configFile) ) {
         throw new Error(
-            `configuration file ${configFile} not exists. Please check your
+            `configuration file ${configFile} does not exist. Please check your
             command line arguments for --config.\n\n`);
     }