Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fci_l1c_fdhsi reader from pending to full deprecation #1713

Open
ameraner opened this issue Jun 1, 2021 · 0 comments
Open

Move fci_l1c_fdhsi reader from pending to full deprecation #1713

ameraner opened this issue Jun 1, 2021 · 0 comments
Assignees
Labels
backwards-incompatibility Causes backwards incompatibility or introduces a deprecation blocked Waiting on an external action (eg release of other package) component:readers

Comments

@ameraner
Copy link
Member

ameraner commented Jun 1, 2021

Feature Request

Is your feature request related to a problem? Please describe.
The fci_l1c_fdhsi reader has been renamed to fci_l1c_nc in #1712. It has been temporarily added to the PENDING_OLD_READER_NAMES, such that users using the old name get just a FutureWarning and have time for a gentle transition until the old reader name is fully deprecated.

This issue is a reminder to send fci_l1c_fdhsi to the OLD_READER_NAMES once enough notice time has passed, and later on remove it also from there.

Describe any changes to existing user workflow
When the reader will be moved to the OLD_READER_NAMES, users will get a hard ValueError and will not be able to use the old name any further.

Additional context
To proceed with the deprecation, it's probably best to wait at least until EUMETSAT updates the reader name in the Pytroll section of its Product User Guide for FCI. See link in https://www.eumetsat.int/mtg-test-data (current version is: https://www-cdn.eumetsat.int/files/2020-07/pdf_mtg_fci_l1_pug.pdf (V1J)).

@ameraner ameraner added component:readers backwards-incompatibility Causes backwards incompatibility or introduces a deprecation blocked Waiting on an external action (eg release of other package) labels Jun 1, 2021
@ameraner ameraner self-assigned this Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompatibility Causes backwards incompatibility or introduces a deprecation blocked Waiting on an external action (eg release of other package) component:readers
Projects
None yet
Development

No branches or pull requests

1 participant