Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UCF101 docstring #4275

Merged
merged 4 commits into from
Aug 27, 2021
Merged

Conversation

bjuncek
Copy link
Contributor

@bjuncek bjuncek commented Aug 13, 2021

Addressing #4270

cc @pmeier

@bjuncek
Copy link
Contributor Author

bjuncek commented Aug 13, 2021

Unitest failing seems unrelated.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bjuncek , I have some minor comments but LGTM anyway!

torchvision/datasets/ucf101.py Outdated Show resolved Hide resolved
Copy link
Contributor

@prabhat00155 prabhat00155 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bjuncek!

@prabhat00155 prabhat00155 merged commit 5ef75d7 into pytorch:main Aug 27, 2021
facebook-github-bot pushed a commit that referenced this pull request Sep 9, 2021
Summary:
* Update UCF101 docstring

* addressing NicolasHugs comments

* Fixed flake8 error

Reviewed By: fmassa

Differential Revision: D30793315

fbshipit-source-id: 7d81c9be09f73308226ab3ba2c5bbda2f6e96d2b

Co-authored-by: Prabhat Roy <prabhatroy@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants