Simplify TestCase.assertExpected() #2815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfdev-5
reviewed
Oct 14, 2020
|
Seems like the CI is a bit confused by the last commit as circle ci tests are not shown... |
|
Same thing is happening on #2812, maybe it's a CircleCI issue? EDIT: Seems to be working now, I'll rebase this on top of master once the other PR gets merged to kick CI again here |
Codecov Report
@@ Coverage Diff @@
## master #2815 +/- ##
==========================================
+ Coverage 73.32% 73.43% +0.11%
==========================================
Files 99 99
Lines 8726 8771 +45
Branches 1374 1376 +2
==========================================
+ Hits 6398 6441 +43
- Misses 1909 1910 +1
- Partials 419 420 +1
Continue to review full report at Codecov.
|
fmassa
approved these changes
Oct 14, 2020
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* Removing unnecessary variable. * Refactoring common_utils.py to remove unused vars. * Removing unused value and changing use of accept_output. Co-authored-by: vfdev <vfdev.5@gmail.com> Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
vfdev-5
added a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
* Removing unnecessary variable. * Refactoring common_utils.py to remove unused vars. * Removing unused value and changing use of accept_output. Co-authored-by: vfdev <vfdev.5@gmail.com> Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor Refactoring on
TestCase.assertExpected()to fix #2814