Cityscapes

[pmeier]

cc @pmeier @bjuncek

[vfdev-5]

In cityscapes we have splits and modes and split names depends on mode value.

vision/torchvision/datasets/cityscapes.py

Lines 123 to 127 in 44e93be

	verify_str_arg(mode, "mode", ("fine", "coarse"))
	if mode == "fine":
	valid_modes = ("train", "test", "val")
	else:
	valid_modes = ("train", "train_extra", "val")

How can we do that in the prototype ?

[NicolasHug]

You can take inspiration from VOC:

vision/torchvision/prototype/datasets/_builtin/voc.py

Lines 41 to 46 in 44e93be

	def make_config(self, **options: Any) -> DatasetConfig:
	config = super().make_config(**options)
	if config.split == "test" and config.year != "2007":
	raise ValueError("`split='test'` is only available for `year='2007'`")
	return config

But the exact way we handle this might slightly change with #5369

[pmeier]

I would say let's wait for #5369 to land before we go ahead with this. Or at least ignore the test and train_extra modes for now.