Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorials : Pretraining VGG from Scrtach #2971

Open
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

woongjoonchoi
Copy link
Contributor

@woongjoonchoi woongjoonchoi commented Jul 13, 2024

Fixes #ISSUE_NUMBER

Description

I make a new tutorial training VGG from scratch . There are no tutorials traning Vgg from scratch.

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @subramen @albanD

saving and loading a general checkpoint.py  \n intial -> initial
toctree : Image and Video

Pretraining Vgg from scratch
Copy link

pytorch-bot bot commented Jul 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2971

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0187f0f with merge base 67ec2a5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@svekars svekars added core Tutorials of any level of difficulty related to the core pytorch functionality intro labels Jul 15, 2024
@@ -0,0 +1,643 @@
"""
In this tutorial, we will embark on an exciting journey to build and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow this template . Your tutorials should have: Title, a short abstract, Author, Overview, Steps, and Conclusion. Please maintain a third-person narrative throughout the document. Avoid using first-person pronouns like "I" and instead use "we". Use active voice where possible.

Follow Pytorch Tutorial convetion

Modify I -> We
Add More things to try  , Conclusion , Further Reading
@woongjoonchoi
Copy link
Contributor Author

woongjoonchoi commented Jul 22, 2024

Hi @svekars, could you please help to take a look of this PR?

@woongjoonchoi
Copy link
Contributor Author

woongjoonchoi commented Jul 24, 2024

Hi @svekars, could you please help to take a look of this PR again?
I fix pyspellchecker issue and package install issue.

@woongjoonchoi
Copy link
Contributor Author

Hi @svekars , could you please help to take a look of this PR again?

Lint and Technical Details and flexible code style
@woongjoonchoi
Copy link
Contributor Author

@svekars Sorry for being late. I've been busy with lab work. I've made some revisions based on the feedback I received. Could you check again?

@svekars
Copy link
Contributor

svekars commented Sep 16, 2024

There is a build error related to the code.

svekars and others added 2 commits September 16, 2024 11:22
Editorial and formatting fixes
Co-authored-by: Joel Schlosser <75754324+jbschlosser@users.noreply.github.com>
* Complete the `Learn the Basics tutorials <https://pytorch.org/tutorials/beginner/basics/intro.html>`__
* Familiarity with basic machine learning concepts and terms

If you are running this in Google Colab, install albumentations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you are running this in Google Colab, install albumentations
If you are running this in Google Colab, install albumentations by running the following command:
.. code-block:: py
!pip install albumentations

beginner_source/Pretraining_Vgg_from_scratch.py Outdated Show resolved Hide resolved
train loader fail
train loader fail
feedback accepted

Re PullRequest because of network issue
index.rst Outdated Show resolved Hide resolved
index.rst Outdated Show resolved Hide resolved
beginner_source/Pretraining_Vgg_from_scratch.py Outdated Show resolved Hide resolved
index.rst Outdated Show resolved Hide resolved
svekars and others added 3 commits September 26, 2024 09:18
Co-authored-by: Joel Schlosser <75754324+jbschlosser@users.noreply.github.com>
@woongjoonchoi
Copy link
Contributor Author

@svekars Are there any other things I need to fix?

@svekars
Copy link
Contributor

svekars commented Oct 8, 2024

This tutorial takes almost 200 minutes to build: https://docs-preview.pytorch.org/pytorch/tutorials/2971/beginner/Pretraining_Vgg_from_scratch.html which we can't support. I suggest you convert this to .rst instead so that it does not run in our CI.

Comment on lines +635 to +642
val_data.transform= A.Compose(
[
A.Normalize(),
A.SmallestMaxSize(max_size=val_data.S),
A.CenterCrop(height =224,width=224)
]

)
Copy link
Contributor

@jbschlosser jbschlosser Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please run lintrunner -a (from here) on the code blocks throughout using the .lintrunner.toml config provided in the base PyTorch repo dir? The use of whitespace is inconsistent and makes the logic hard to read

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed core Tutorials of any level of difficulty related to the core pytorch functionality intro
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants