-
Notifications
You must be signed in to change notification settings - Fork 4.3k
update profiler tutorial with new features introduced #1568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✔️ Deploy Preview for pytorch-tutorials-preview ready! 🔨 Explore the source changes: 4fca534 🔍 Inspect the deploy log: https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/60d3c76f6ca8900007f920c6 😎 Browse the preview: https://deploy-preview-1568--pytorch-tutorials-preview.netlify.app |
6013ba7 to
7550125
Compare
5ffc6b9 to
7f0e919
Compare
| # after which the trace will become available and on_trace_ready (when set) is called. | ||
| # The cycle repeats twice totally. Each cycle is called a "span" in TensorBoard plugin. | ||
| # | ||
| # During ``wait`` steps, the profiler does not work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unclear as to what that means
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the profiler disabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to "the profiler is disabled".
| # :scale: 25 % | ||
| # | ||
| # The "Computation/Communication Overview" shows computation/communication ratio and their overlapping degree. | ||
| # User can get the load balance between workers from it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear. Do you mean "User can retrieve the load balance from/between the workers"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about "From this view, user can figure out load balance issue among workers."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! I love that.
6517b8f to
548e2e5
Compare
548e2e5 to
e303fa6
Compare
sabrina-smai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
|
@gaoteng-git This looks good, thanks for the updates |
* update profiler tutorial with new features introduced * update bigger to higher * change wording and add some links Co-authored-by: Brian Johnson <brianjo@fb.com>
Introduce new features such as: