Test include stride_per_key to KJT's flatten and unflatten #2903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73051959 |
jd7-tr
force-pushed
the
export-D73051959
branch
from
ce9124e to
7fef289
Compare
jd7-tr
added a commit
to jd7-tr/torchrec
that referenced
this pull request
Apr 25, 2025
) Summary: # Context * Currently torchrec IR serializer can't handle variable batch use case. * `torch.export` only captures the keys, values, lengths, weights, offsets of a KJT, however, some variable-batch related parameters like `stride_per_rank` or `inverse_indices` would be ignored. * This test case (expected failure right now) covers the vb-KJT scenario for verifying that the serialize_deserialize_ebc use case works fine with KJTs with variable batch size. # Ref Differential Revision: D73051959
|
This pull request was exported from Phabricator. Differential Revision: D73051959 |
jd7-tr
force-pushed
the
export-D73051959
branch
from
7fef289 to
6a3d229
Compare
jd7-tr
added a commit
to jd7-tr/torchrec
that referenced
this pull request
Apr 26, 2025
) Summary: # Context * Currently torchrec IR serializer can't handle variable batch use case. * `torch.export` only captures the keys, values, lengths, weights, offsets of a KJT, however, some variable-batch related parameters like `stride_per_rank` or `inverse_indices` would be ignored. * This test case (expected failure right now) covers the vb-KJT scenario for verifying that the serialize_deserialize_ebc use case works fine with KJTs with variable batch size. # Ref Differential Revision: D73051959
|
This pull request was exported from Phabricator. Differential Revision: D73051959 |
jd7-tr
added a commit
to jd7-tr/torchrec
that referenced
this pull request
Apr 29, 2025
…ic (pytorch#2903) Summary: # Context * Currently torchrec IR serializer can't handle variable batch use case. * `torch.export` only captures the keys, values, lengths, weights, offsets of a KJT, however, some variable-batch related parameters like `stride_per_rank` or `inverse_indices` would be ignored. * This test case (expected failure right now) covers the vb-KJT scenario for verifying that the serialize_deserialize_ebc use case works fine with KJTs with variable batch size. # Ref Differential Revision: D73051959
jd7-tr
added a commit
to jd7-tr/torchrec
that referenced
this pull request
Apr 29, 2025
…ic (pytorch#2903) Summary: # Context * Currently torchrec IR serializer can't handle variable batch use case. * `torch.export` only captures the keys, values, lengths, weights, offsets of a KJT, however, some variable-batch related parameters like `stride_per_rank` or `inverse_indices` would be ignored. * This test case (expected failure right now) covers the vb-KJT scenario for verifying that the serialize_deserialize_ebc use case works fine with KJTs with variable batch size. # Ref Differential Revision: D73051959
jd7-tr
force-pushed
the
export-D73051959
branch
from
6a3d229 to
e38a01e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73051959 |
jd7-tr
added a commit
to jd7-tr/torchrec
that referenced
this pull request
Apr 30, 2025
…ic (pytorch#2903) Summary: # Context * Currently torchrec IR serializer can't handle variable batch use case. * `torch.export` only captures the keys, values, lengths, weights, offsets of a KJT, however, some variable-batch related parameters like `stride_per_rank` or `inverse_indices` would be ignored. * This test case (expected failure right now) covers the vb-KJT scenario for verifying that the serialize_deserialize_ebc use case works fine with KJTs with variable batch size. # Ref Differential Revision: D73051959
…ic (pytorch#2903) Summary: # Context * Currently torchrec IR serializer can't handle variable batch use case. * `torch.export` only captures the keys, values, lengths, weights, offsets of a KJT, however, some variable-batch related parameters like `stride_per_rank` or `inverse_indices` would be ignored. * This test case (expected failure right now) covers the vb-KJT scenario for verifying that the serialize_deserialize_ebc use case works fine with KJTs with variable batch size. # Ref Differential Revision: D73051959
|
This pull request was exported from Phabricator. Differential Revision: D73051959 |
jd7-tr
added a commit
to jd7-tr/torchrec
that referenced
this pull request
May 1, 2025
…ic (pytorch#2903) Summary: # Context * Currently torchrec IR serializer can't handle variable batch use case. * `torch.export` only captures the keys, values, lengths, weights, offsets of a KJT, however, some variable-batch related parameters like `stride_per_rank` or `inverse_indices` would be ignored. * This test case (expected failure right now) covers the vb-KJT scenario for verifying that the serialize_deserialize_ebc use case works fine with KJTs with variable batch size. # Ref Differential Revision: D73051959
jd7-tr
pushed a commit
to jd7-tr/torchrec
that referenced
this pull request
May 1, 2025
…ic (pytorch#2903) Summary: Pull Request resolved: pytorch#2903 # Context * Currently torchrec IR serializer can't handle variable batch use case. * `torch.export` only captures the keys, values, lengths, weights, offsets of a KJT, however, some variable-batch related parameters like `stride_per_rank` or `inverse_indices` would be ignored. * This test case (expected failure right now) covers the vb-KJT scenario for verifying that the serialize_deserialize_ebc use case works fine with KJTs with variable batch size. # Ref Differential Revision: D73051959
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D73051959