Add rpath fixups to Mac non-GPL FFmpeg build

Author: scotts

.github/workflows/build_ffmpeg.yaml

@@ -9,10 +9,16 @@
 # per new major release of FFmepg.
 name: Build non-GPL FFmpeg from source
 
+  #on:
+  #  workflow_dispatch:
+  #  schedule:
+  #    - cron: '0 0 * * 0'  # on sunday
+
 on:
-  workflow_dispatch:
-  schedule:
-    - cron: '0 0 * * 0'  # on sunday
+  push:
+    branches: [ main ]
+  pull_request:
+
 
 defaults:
   run:

packaging/build_ffmpeg.sh

@@ -64,3 +64,90 @@ tar -xf ffmpeg.tar.gz --strip-components 1
 
 make -j install
 ls ${prefix}/*
+
+# macos: Fix rpath so that the libraries are searched dynamically in user environment.
+# In Linux, this is handled by `--enable-rpath` flag.
+if [[ "$(uname)" == Darwin ]]; then
+    ffmpeg_version="${FFMPEG_VERSION:-4.1.8}"
+    major_ver=${ffmpeg_version:0:1}
+    if [[ ${major_ver} == 4 ]]; then
+        avutil=libavutil.56
+        avcodec=libavcodec.58
+        avformat=libavformat.58
+        avdevice=libavdevice.58
+        avfilter=libavfilter.7
+    elif [[ ${major_ver} == 5 ]]; then
+        avutil=libavutil.57
+        avcodec=libavcodec.59
+        avformat=libavformat.59
+        avdevice=libavdevice.59
+        avfilter=libavfilter.8
+    elif [[ ${ffmpeg_version} == master || ${major_ver} == 6 ]]; then
+        avutil=libavutil.58
+        avcodec=libavcodec.60
+        avformat=libavformat.60
+        avdevice=libavdevice.60
+        avfilter=libavfilter.9
+    else
+        printf "Error: unexpected FFmpeg major version: %s\n"  ${major_ver}
+        exit 1;
+    fi
+
+    otool="/usr/bin/otool"
+    # NOTE: miniconda has a version of otool and install_name_tool installed and we want
+    #       to use the default sytem version instead of the miniconda version since the miniconda
+    #       version can produce inconsistent results
+
+    # Attempt to use /usr/bin/otool as our default otool
+    if [[ ! -e ${otool} ]]; then
+        otool="$(which otool)"
+    fi
+    install_name_tool="/usr/bin/install_name_tool"
+    # Attempt to use /usr/bin/install_name_tool as our default install_name_tool
+    if [[ ! -e ${install_name_tool} ]]; then
+        install_name_tool="$(which install_name_tool)"
+    fi
+
+    # list up the paths to fix
+    for lib in ${avcodec} ${avdevice} ${avfilter} ${avformat} ${avutil}; do
+        ${otool} -l ${prefix}/lib/${lib}.dylib | grep -B2 ${prefix}
+    done
+
+    # Replace the hardcoded paths to @rpath
+    ${install_name_tool} \
+        -change ${prefix}/lib/${avutil}.dylib @rpath/${avutil}.dylib \
+        -delete_rpath ${prefix}/lib \
+        -id @rpath/${avcodec}.dylib \
+        ${prefix}/lib/${avcodec}.dylib
+    ${otool} -l ${prefix}/lib/${avcodec}.dylib | grep -B2 ${prefix}
+
+    ${install_name_tool} \
+        -change ${prefix}/lib/${avformat}.dylib @rpath/${avformat}.dylib \
+        -change ${prefix}/lib/${avcodec}.dylib @rpath/${avcodec}.dylib \
+        -change ${prefix}/lib/${avutil}.dylib @rpath/${avutil}.dylib \
+        -delete_rpath ${prefix}/lib \
+        -id @rpath/${avdevice}.dylib \
+        ${prefix}/lib/${avdevice}.dylib
+    ${otool} -l ${prefix}/lib/${avdevice}.dylib | grep -B2 ${prefix}
+
+    ${install_name_tool} \
+        -change ${prefix}/lib/${avutil}.dylib @rpath/${avutil}.dylib \
+        -delete_rpath ${prefix}/lib \
+        -id @rpath/${avfilter}.dylib \
+        ${prefix}/lib/${avfilter}.dylib
+    ${otool} -l ${prefix}/lib/${avfilter}.dylib | grep -B2 ${prefix}
+
+    ${install_name_tool} \
+        -change ${prefix}/lib/${avcodec}.dylib @rpath/${avcodec}.dylib \
+        -change ${prefix}/lib/${avutil}.dylib @rpath/${avutil}.dylib \
+        -delete_rpath ${prefix}/lib \
+        -id @rpath/${avformat}.dylib \
+        ${prefix}/lib/${avformat}.dylib
+    ${otool} -l ${prefix}/lib/${avformat}.dylib | grep -B2 ${prefix}
+
+    ${install_name_tool} \
+        -delete_rpath ${prefix}/lib \
+        -id @rpath/${avutil}.dylib \
+        ${prefix}/lib/${avutil}.dylib
+    ${otool} -l ${prefix}/lib/${avutil}.dylib | grep -B2 ${prefix}
+fi