fix: enforce python version #1345
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1345
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4246c57 with merge base e30aaa0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @leseb! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
CLA is in-progress. |
leseb
force-pushed
the
enforce-python3.10
branch
2 times, most recently
from
e03ae74 to
a2fee7b
Compare
|
Looks like there's some updates required from the CI side, able to take a look? "Python version must be 3.10.x or 3.11.x. Detected version: 3.11" |
Certainly! |
leseb
force-pushed
the
enforce-python3.10
branch
from
a2fee7b to
01b73c3
Compare
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
The previous Python version check was incorrect, allowing installations on unsupported interpreter versions, which caused installation failures. Additionally, we now respect the specified interpreter version if provided, consistently using it throughout the installation process by enforcing it with pip. Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
force-pushed
the
enforce-python3.10
branch
from
01b73c3 to
4246c57
Compare
| if [[ $? -ne 0 ]] | ||
| if ! $PYTHON_EXECUTABLE -c " | ||
| import sys | ||
| if sys.version_info < (3, 10) or sys.version_info >= (3, 12): |
There was a problem hiding this comment.
what's wrong with 3.12? that seems to be what I have on my Mac and I don't think I've updated recently.
There was a problem hiding this comment.
It was based on the existing comments (which we just happen to not enforce)
That said, let's open up 3.12 since that's been looking fine to me
There was a problem hiding this comment.
That's what I get for reviewing code after 1AM
There was a problem hiding this comment.
I don’t see any issues with 3.12. The main question is less about whether it works on 3.12 and more about which version the project currently aims to support. Opened a followup PR to address this.
The previous Python version check was incorrect, allowing installations on unsupported interpreter versions, which caused installation failures. Additionally, we now respect the specified interpreter version if provided, consistently using it throughout the installation process by enforcing it with pip. Signed-off-by: Sébastien Han <seb@redhat.com>
4246c57 fix: enforce python version
commit 4246c57
Author: Sébastien Han seb@redhat.com
Date: Wed Nov 6 10:30:24 2024 +0100