Skip to content

enable llava on torchchat #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

enable llava on torchchat #1183

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f52007e
llava e2e 1/n
Gasoonjia Sep 23, 2024
32d969e
2/n llava e2e init
Gasoonjia Sep 23, 2024
9e4350d
3/n llava e2e init
Gasoonjia Sep 23, 2024
72d7b96
n/n llava e2e
Gasoonjia Sep 24, 2024
dfe37b8
remove extra debug files
Gasoonjia Sep 24, 2024
1834696
merge main
Gasoonjia Sep 24, 2024
8ecc2fa
remove extra debug code
Gasoonjia Sep 24, 2024
a70d7b5
remove extra print
Gasoonjia Sep 24, 2024
937e7ed
remove input pos keyword in generate.py
Gasoonjia Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove extra print
  • Loading branch information
@Gasoonjia
Gasoonjia committed Sep 24, 2024
commit a70d7b51b54f1b0015ee9bc0e8508636f7129e55
2 changes: 0 additions & 2 deletions torchchat/cli/convert_hf_checkpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,6 @@ def convert_hf_checkpoint(
model_name: Optional[str] = None,
remove_bin_files: bool = False,
):
print(model_name)
print("***********************")
if "llava" in model_name:
convert_llava_checkpoint(model_dir=model_dir)
else:
Expand Down
6 changes: 0 additions & 6 deletions torchchat/cli/download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,16 +80,10 @@ def download_and_convert(
# allows recovery in the event that the download or conversion
# fails unexpectedly.
temp_dir = models_dir / "downloads" / model_config.name
# temp_dir = Path("/home/gasoonjia") / "downloads" / model_config.name

if os.path.isdir(temp_dir):
shutil.rmtree(temp_dir)
os.makedirs(temp_dir, exist_ok=True)

print("**************************************************")
print("**************************************************")
print("temp dir: ", temp_dir)

try:
if (
model_config.distribution_channel
Expand Down
Loading