Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open AI API Maturity #973

Open
Jack-Khuu opened this issue Jul 30, 2024 · 4 comments · Fixed by #995 or #1000
Open

Open AI API Maturity #973

Jack-Khuu opened this issue Jul 30, 2024 · 4 comments · Fixed by #995 or #1000
Labels
Known Gaps These are known Gaps/Issues/Bug items in torchchat

Comments

@Jack-Khuu
Copy link
Contributor

Jack-Khuu commented Jul 30, 2024

🚀 The feature, motivation and pitch

The OpenAI API support in torchchat is actively in development and will be one of the main entry point for interacting with torchchat

https://github.com/pytorch/torchchat?tab=readme-ov-file#server

Alternatives

No response

Additional context

No response

RFC (Optional)

No response

@Jack-Khuu Jack-Khuu added the Known Gaps These are known Gaps/Issues/Bug items in torchchat label Jul 30, 2024
@vmpuri
Copy link
Contributor

vmpuri commented Aug 2, 2024

PR 995 addresses some initial concerns. Responses should now be formatted in JSON using the API dataclasses. Here are our functional gaps so far:

  • system_fingerprint/seed implementation is incomplete. We need to figure out a good way to create and consume fingerprints from seeds. For now, the client cannot control reproducibility of the responses.
  • model cannot be selected by the client. The model is selected when starting the server and cannot be changed without exiting the process. The server does not check to ensure the request/response models match
  • Agentic behavior/toolcall functionality is unimplemented. We will focus on getting chat right first, then create entrypoints for tool usecases.

Behavior Issues

@ywang96
Copy link

ywang96 commented Aug 4, 2024

Hello there! I'm curious if supporting OpenAI Vision API is also something you're interested in since it looks like the team does plan to support vision language models from the discussion in #988

If you do, happy to help!

This was linked to pull requests Aug 6, 2024
@vmpuri
Copy link
Contributor

vmpuri commented Aug 6, 2024

Hey Roger, thanks for reaching out! We do plan on adding LLaVA support in the coming weeks, and we'd appreciate your help on the API/server components.

I'm still working on bringing the initial version of the API and server up to spec, but I'll keep this issue updated with my progress.

@vmpuri
Copy link
Contributor

vmpuri commented Aug 19, 2024

Landed pulls #1035 #1034 #1042 which prove that the basic completion API works as expected with the Python OpenAI API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Known Gaps These are known Gaps/Issues/Bug items in torchchat
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants